Differential D3942

Remove useless logging to Sentry.
ClosedPublic
Actions

Authored by vlorentz on Sep 14 2020, 5:56 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPS37cd0a8bcee2: Remove useless logging to Sentry.

Summary

And simply use an 'if' instead of 'except Exception', which is
broader than what we need.

Diff Detail

Repository

rDWAPPS Web applications

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 15108
Build 23294: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 23293: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	2 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.common.test_highlightjs::Tests / Python tests / test_get_hljs_language_from_mime_type def test_get_hljs_language_from_mime_type(): lang = highlightjs.get_hljs_language_from_mime_type("text/plain") assert lang is None
	209 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_accept_pending_save_request
	643 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_authorized_origin_url
	118 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_add_unauthorized_origin_url
	125 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_origin_save::Tests / Python tests / test_reject_pending_save_request
		View Full Test Results (1 Failed · 561 Passed · 7 Skipped)

Event Timeline

vlorentz created this revision.Sep 14 2020, 5:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 14 2020, 5:56 PM

Build has FAILED

Patch application report for D3942 (id=13884)

Rebasing onto 6efd8fac28...

Current branch diff-target is up to date.

Changes applied before test

commit efc10791498cfc979c89fdffbd0e206b1573a0cd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 17:55:51 2020 +0200

    Remove useless logging to Sentry.
    
    And simply use an 'if' instead of 'except Exception', which is
    broader than what we need.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/360/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/360/console

Harbormaster failed remote builds in B15108: Diff 13884!Sep 14 2020, 6:02 PM

Build has FAILED

Patch application report for D3942 (id=13884)

Rebasing onto 6efd8fac28...

Current branch diff-target is up to date.

Changes applied before test

commit efc10791498cfc979c89fdffbd0e206b1573a0cd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 17:55:51 2020 +0200

    Remove useless logging to Sentry.
    
    And simply use an 'if' instead of 'except Exception', which is
    broader than what we need.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/361/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/361/console

I have the feeling that other captured exceptions in swh-web codebase could not be sent to sentry as they are indeed useless to analyze. I will try to make a pass on them during the week.

Test failure is related to the new Pygments release (D3943).

This revision is now accepted and ready to land.Sep 14 2020, 7:25 PM

rebase

Build is green

Patch application report for D3942 (id=13901)

Rebasing onto 16ab03ab45...

Current branch diff-target is up to date.

Changes applied before test

commit 37cd0a8bcee2b1f265895c61ee50a3ce39ee4f95
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 14 17:55:51 2020 +0200

    Remove useless logging to Sentry.
    
    And simply use an 'if' instead of 'except Exception', which is
    broader than what we need.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/363/ for more details.

Harbormaster completed remote builds in B15125: Diff 13901.Sep 15 2020, 11:42 AM

37cd0a8bcee2b1f265895c61ee50a3ce39ee4f95

vlorentz added a commit: rDWAPPS37cd0a8bcee2: Remove useless logging to Sentry..Sep 15 2020, 1:19 PM