And simply use an 'if' instead of 'except Exception', which is
broader than what we need.
Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Commits
- rDWAPPS37cd0a8bcee2: Remove useless logging to Sentry.
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 15125 Build 23317: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 23316: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D3942 (id=13884)
Rebasing onto 6efd8fac28...
Current branch diff-target is up to date.
Changes applied before test
commit efc10791498cfc979c89fdffbd0e206b1573a0cd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Sep 14 17:55:51 2020 +0200
Remove useless logging to Sentry.
And simply use an 'if' instead of 'except Exception', which is
broader than what we need.Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/360/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/360/console
Comment Actions
Build has FAILED
Patch application report for D3942 (id=13884)
Rebasing onto 6efd8fac28...
Current branch diff-target is up to date.
Changes applied before test
commit efc10791498cfc979c89fdffbd0e206b1573a0cd
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Sep 14 17:55:51 2020 +0200
Remove useless logging to Sentry.
And simply use an 'if' instead of 'except Exception', which is
broader than what we need.Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/361/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/361/console
Comment Actions
I have the feeling that other captured exceptions in swh-web codebase could not be sent to sentry as they are indeed useless to analyze. I will try to make a pass on them during the week.
Test failure is related to the new Pygments release (D3943).
Comment Actions
Build is green
Patch application report for D3942 (id=13901)
Rebasing onto 16ab03ab45...
Current branch diff-target is up to date.
Changes applied before test
commit 37cd0a8bcee2b1f265895c61ee50a3ce39ee4f95
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Mon Sep 14 17:55:51 2020 +0200
Remove useless logging to Sentry.
And simply use an 'if' instead of 'except Exception', which is
broader than what we need.See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/363/ for more details.