Differential D3850

auth: Simplify authentication after changes in swh-web
ClosedPublic
Actions

Authored by anlambert on Aug 27 2020, 1:42 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWCLIf3d89ebc4ec1: auth: Simplify authentication after changes in swh-web

Summary

Token renewal workflow is now delegated to swh-web for commodity of use when
a user wants to make authenticated API calls.

So remove no more needed code and update documentation regarding authentication.

Depends on D3849

Diff Detail

Repository

rDWCLI Web client

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Aug 27 2020, 1:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 27 2020, 1:42 PM

Build has FAILED

Patch application report for D3850 (id=13599)

Rebasing onto ca947d48a2...

Current branch diff-target is up to date.

Changes applied before test

commit 89b1cf89cff5abfc7edcc91015ecacd94307ff71
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Aug 27 13:39:05 2020 +0200

    auth: Simplify authentication after changes in swh-web
    
    Token renewal workflow is now delegated to swh-web for commodity of use when
    a user wants to make authenticated API calls.
    
    So remove no more needed code and update documentation regarding authentication.

Link to build: https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/11/
See console output for more information: https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/11/console

Harbormaster failed remote builds in B14829: Diff 13599!Aug 27 2020, 1:43 PM

Forgot to update tests.

Build is green

Patch application report for D3850 (id=13600)

Rebasing onto ca947d48a2...

Current branch diff-target is up to date.

Changes applied before test

commit 2821a32d73639901c68ee154a6b3b18854c37524
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Aug 27 13:39:05 2020 +0200

    auth: Simplify authentication after changes in swh-web
    
    Token renewal workflow is now delegated to swh-web for commodity of use when
    a user wants to make authenticated API calls.
    
    So remove no more needed code and update documentation regarding authentication.

See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/12/ for more details.

Harbormaster completed remote builds in B14830: Diff 13600.Aug 27 2020, 2:08 PM

vlorentz accepted this revision.Aug 27 2020, 4:58 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

docs/index.rst
12–44	I preferred it plural, it sounds more idiomatic
swh/web/client/auth.py
19	revoked
swh/web/client/client.py
135	d/get/do/

This revision is now accepted and ready to land.Aug 27 2020, 4:58 PM

Update: Address @vlorentz comments

Build is green

Patch application report for D3850 (id=13602)

Rebasing onto ca947d48a2...

Current branch diff-target is up to date.

Changes applied before test

commit f3d89ebc4ec1bcbb0b0de4cf9bdabab5ce1df09b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Aug 27 13:39:05 2020 +0200

    auth: Simplify authentication after changes in swh-web
    
    Token renewal workflow is now delegated to swh-web for commodity of use when
    a user wants to make authenticated API calls.
    
    So remove no more needed code and update documentation regarding authentication.

See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/13/ for more details.

Harbormaster completed remote builds in B14832: Diff 13602.Aug 27 2020, 5:43 PM

Closed by commit rDWCLIf3d89ebc4ec1: auth: Simplify authentication after changes in swh-web (authored by anlambert). · Explain WhyAug 27 2020, 6:53 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWCLIf3d89ebc4ec1: auth: Simplify authentication after changes in swh-web.