Page MenuHomeSoftware Heritage

auth: Simplify authentication after changes in swh-web
ClosedPublic

Authored by anlambert on Aug 27 2020, 1:42 PM.

Details

Summary

Token renewal workflow is now delegated to swh-web for commodity of use when
a user wants to make authenticated API calls.

So remove no more needed code and update documentation regarding authentication.

Depends on D3849

Diff Detail

Repository
rDWCLI Web client
Branch
client-auth-simplify
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14830
Build 22846: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 22845: arc lint + arc unit

Event Timeline

Build has FAILED

Patch application report for D3850 (id=13599)

Rebasing onto ca947d48a2...

Current branch diff-target is up to date.
Changes applied before test
commit 89b1cf89cff5abfc7edcc91015ecacd94307ff71
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Aug 27 13:39:05 2020 +0200

    auth: Simplify authentication after changes in swh-web
    
    Token renewal workflow is now delegated to swh-web for commodity of use when
    a user wants to make authenticated API calls.
    
    So remove no more needed code and update documentation regarding authentication.

Link to build: https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/11/
See console output for more information: https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/11/console

Build is green

Patch application report for D3850 (id=13600)

Rebasing onto ca947d48a2...

Current branch diff-target is up to date.
Changes applied before test
commit 2821a32d73639901c68ee154a6b3b18854c37524
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Aug 27 13:39:05 2020 +0200

    auth: Simplify authentication after changes in swh-web
    
    Token renewal workflow is now delegated to swh-web for commodity of use when
    a user wants to make authenticated API calls.
    
    So remove no more needed code and update documentation regarding authentication.

See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/12/ for more details.

vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
docs/index.rst
12–44

I preferred it plural, it sounds more idiomatic

swh/web/client/auth.py
19

revoked

swh/web/client/client.py
135

d/get/do/

This revision is now accepted and ready to land.Aug 27 2020, 4:58 PM

Build is green

Patch application report for D3850 (id=13602)

Rebasing onto ca947d48a2...

Current branch diff-target is up to date.
Changes applied before test
commit f3d89ebc4ec1bcbb0b0de4cf9bdabab5ce1df09b
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Thu Aug 27 13:39:05 2020 +0200

    auth: Simplify authentication after changes in swh-web
    
    Token renewal workflow is now delegated to swh-web for commodity of use when
    a user wants to make authenticated API calls.
    
    So remove no more needed code and update documentation regarding authentication.

See https://jenkins.softwareheritage.org/job/DWCLI/job/tests-on-diff/13/ for more details.