161: Fix sql upgrade script
ClosedPublic
Actions

Authored by ardumont on Aug 24 2020, 4:45 PM.

Details

Reviewers

vlorentz
douardda
anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T2524: Storage database migration tooling

Commits

rDSTOf3870dcd07dc: 161: Fix sql upgrade script

Summary

Prior to this commit, the existing script did not work:

swh=> rollback; begin; update revision set extra_headers = ARRAY[][] where extra_headers is null;
ROLLBACK
BEGIN
ERROR:  syntax error at or near "["
LINE 1: update revision set extra_headers = ARRAY[][] where extra_he...

With the following diff's content, on staging:

swh=> rollback; begin; update revision set extra_headers = ARRAY[]::bytea[][] where extra_headers is null;
ROLLBACK
BEGIN
UPDATE 865732
swh=> select extra_headers from revision where extra_headers = ARRAY[]::bytea[][] limit 10;
 extra_headers
 ---------------
  {}
...

I guess it's kinda related to T2524 ;)

Test Plan

manual run on staging prior to actually deploy on production

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Aug 24 2020, 4:45 PM

anlambert accepted this revision.Aug 24 2020, 4:49 PM

This revision is now accepted and ready to land.Aug 24 2020, 4:49 PM

ardumont edited the summary of this revision. (Show Details)Aug 24 2020, 4:50 PM

vlorentz accepted this revision.Aug 24 2020, 4:53 PM

Build is green

Patch application report for D3833 (id=13492)

Rebasing onto f570f9336c...

First, rewinding head to replay your work on top of it...
Applying: 161: Fix sql upgrade script

Changes applied before test

commit 1ce82b790cc48e7495f8694bbbb16d41a503e5f9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Aug 24 16:38:08 2020 +0200

    161: Fix sql upgrade script
    
    Related to T2524

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/854/ for more details.

Harbormaster completed remote builds in B14752: Diff 13492.Aug 24 2020, 4:58 PM

Rebase

Build is green

Patch application report for D3833 (id=13508)

Rebasing onto cc33dd3596...

Current branch diff-target is up to date.

Changes applied before test

commit f3870dcd07dc39838278aef6365e3ed8a6e0b261
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Mon Aug 24 16:38:08 2020 +0200

    161: Fix sql upgrade script
    
    Related to T2524

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/865/ for more details.

Harbormaster completed remote builds in B14768: Diff 13508.Aug 25 2020, 9:44 AM

Closed by commit rDSTOf3870dcd07dc: 161: Fix sql upgrade script (authored by ardumont). · Explain WhyAug 25 2020, 9:47 AM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTOf3870dcd07dc: 161: Fix sql upgrade script.