Related to T2494
Details
Details
- Reviewers
douardda - Group Reviewers
Reviewers - Maniphest Tasks
- T2494: tests: Use data model objects within tests (drop dicts)
- Commits
- rDSTO2b239f02f69c: test_cassandra: Use data model object
tox
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13752 Build 21072: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 21071: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D3554 (id=12529)
Rebasing onto eb2bf8ce68...
Current branch diff-target is up to date.
Changes applied before test
commit 2b239f02f69c54d067c16054a15976268acbdd12
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Fri Jul 17 16:37:31 2020 +0200
test_cassandra: Use data model object
Related to T2494See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/474/ for more details.
Comment Actions
not sure I like too much the
cont, cont2 = [
attr.evolve(c, ctime=now()) for c in sample_data_model["content"][:2]
]stuff but oh well.
(I mean I find this easier to read:
cont = attr.evolve(sample_data_model["content"][0], ctime=now()) cont2 = attr.evolve(sample_data_model["content"][1], ctime=now())
)
Comment Actions
That's most probably because i like destructuring a lot (from other languages ;)
If you don't push much more than that though, i'll keep as it is (i'm lazy today ;)