Page MenuHomeSoftware Heritage

test_cli: Use snapshot model object within test
ClosedPublic

Authored by ardumont on Jul 16 2020, 5:32 PM.

Details

Summary

That commit is not so interesting. But at least we validate the snapshot is
correct prior to sending it.

Also that removes a bit duplicated storage configuration.

Related to T2494

Test Plan

tox

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13702
Build 20993: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 20992: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D3535 (id=12478)

Rebasing onto 2d4f727139...

Current branch diff-target is up to date.
Changes applied before test
commit cd3680dcba5bd5565e30f24c20dab68b8850a320
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 17:31:28 2020 +0200

    test_cli: Use snapshot model object within test
    
    That commit is not so interesting. But at least we validate the snapshot is
    correct prior to sending it.
    
    Also that removesa bit duplicated storage configuration.
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/471/ for more details.

anlambert added a subscriber: anlambert.
anlambert added inline comments.
swh/storage/tests/test_cli.py
79

you can remove that line, real id will be computed when creating the Snapshot object

This revision is now accepted and ready to land.Jul 16 2020, 5:49 PM
  • Adapt according to review (drop the foo id as this will get computed itself by the model object \m/)
  • Fix typo in commit message
swh/storage/tests/test_cli.py
79

thx!

Build is green

Patch application report for D3535 (id=12482)

Rebasing onto 2d4f727139...

Current branch diff-target is up to date.
Changes applied before test
commit 04d25df5a2ee63ad4cccd7656e047d46b75b1eef
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Jul 16 17:31:28 2020 +0200

    test_cli: Use snapshot model object within test
    
    That commit is not so interesting. But at least we validate the snapshot is
    correct prior to sending it.
    
    Also that removes a bit duplicated storage configuration.
    
    Related to T2494

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/472/ for more details.