Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Maniphest Tasks
- T2494: tests: Use data model objects within tests (drop dicts)
- Commits
- rDSTO2ff4c6fcd5e7: test_buffer: Use model objects in tests and drop validate proxy
tox
Diff Detail
Diff Detail
- Repository
- rDSTO Storage manager
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13642 Build 20896: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 20895: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D3512 (id=12421)
Could not rebase; Attempt merge onto f5811da184...
Updating f5811da1..1fb2cc42 Fast-forward swh/storage/pytest_plugin.py | 43 +++- swh/storage/tests/conftest.py | 23 -- swh/storage/tests/test_buffer.py | 143 ++++++------- swh/storage/tests/test_pytest_plugin.py | 60 ++++++ swh/storage/tests/test_retry.py | 368 +++++++++++++++----------------- 5 files changed, 345 insertions(+), 292 deletions(-) create mode 100644 swh/storage/tests/test_pytest_plugin.py
Changes applied before test
commit 1fb2cc42b053f37d276e61900eeb442a6627f667
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Wed Jul 15 19:29:45 2020 +0200
test_buffer: Use model objects in tests and drop validate proxy
commit 11d3e162318873a76f9956c5795f1eb0e03ccd7c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Wed Jul 15 19:07:32 2020 +0200
test_retry: Drop validate proxy when we can
When we use the sample_data_model (almost all object types except the metadata
ones), we can use a storage with no validate proxy.
Depends on D3510
commit 2e1ca5a2132545ab793f0a2e3cc74afd0afb7223
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Wed Jul 15 17:40:04 2020 +0200
test_retry: Use sample_data_model fixture to manipulate model objects
commit 60a2dae6b461245cd6532e234cf651b247264b3c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Wed Jul 15 17:03:33 2020 +0200
pytest-plugin: Expose a sample_data_model fixture
This is almost the same fixture as sample_data except:
- it's BaseModel object instance within
- not complete as we cannot convert yet the metadata objects (there is a diff
pending which will allow it but right now we cannot).
The next commits will use this fixture to allow the switch from dict to model
objects.See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/455/ for more details.
Comment Actions
Build is green
Patch application report for D3512 (id=12446)
Could not rebase; Attempt merge onto 14b1648889...
Updating 14b16488..2ff4c6fc Fast-forward swh/storage/tests/test_buffer.py | 143 +++++++++++++++++++-------------------- swh/storage/tests/test_retry.py | 93 ++++++++++++++----------- 2 files changed, 124 insertions(+), 112 deletions(-)
Changes applied before test
commit 2ff4c6fcd5e760ec5895609aba784995335bb5b1
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Wed Jul 15 19:29:45 2020 +0200
test_buffer: Use model objects in tests and drop validate proxy
commit df45641008cd4a74db1d40f307a70013bed6f7b8
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date: Wed Jul 15 19:07:32 2020 +0200
test_retry: Drop validate proxy when we can
When we use the sample_data_model (almost all object types except the metadata
ones), we can use a storage with no validate proxy.
Depends on D3510See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/462/ for more details.