Page MenuHomeSoftware Heritage

api/identifiers: Adapt to swh-model >= 0.5.0
ClosedPublic

Authored by anlambert on Jul 8 2020, 4:46 PM.

Details

Summary

SWHID is not a namedtuple anymore but a class.

Depends on D3465

Test Plan

Tests will fail until swh-model 0.5.0 is tagged.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jul 8 2020, 4:46 PM

Build has FAILED

Patch application report for D3467 (id=12266)

Rebasing onto 423ac84653...

Current branch diff-target is up to date.
Changes applied before test
commit 970bd672e60fdd34031ed8510b7a2e2f96ff2b55
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jul 8 16:45:02 2020 +0200

    api/identifiers: Adapt to swh-model >= 0.5.0
    
    SWHID is not a namedtuple anymore but a class.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/268/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/268/console

ardumont accepted this revision.Jul 8 2020, 5:04 PM
This revision is now accepted and ready to land.Jul 8 2020, 5:04 PM

Build has FAILED

Patch application report for D3467 (id=12266)

Rebasing onto 423ac84653...

Current branch diff-target is up to date.
Changes applied before test
commit 970bd672e60fdd34031ed8510b7a2e2f96ff2b55
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jul 8 16:45:02 2020 +0200

    api/identifiers: Adapt to swh-model >= 0.5.0
    
    SWHID is not a namedtuple anymore but a class.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/269/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/269/console

Build is green

Patch application report for D3467 (id=12286)

Rebasing onto 0af42367cd...

Current branch diff-target is up to date.
Changes applied before test
commit 2a91164b696d9f30d94c96b1520a8f66b2025b6c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jul 8 16:45:02 2020 +0200

    api/identifiers: Adapt to swh-model >= 0.5.0
    
    SWHID is not a namedtuple anymore but a class.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/271/ for more details.

This revision was automatically updated to reflect the committed changes.