Paths

Table of Contentst

Differential D3467

= 0.5.0
ClosedPublic
Actions

Authored by anlambert on Jul 8 2020, 4:46 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS2a91164b696d: api/identifiers: Adapt to swh-model >= 0.5.0

Summary

SWHID is not a namedtuple anymore but a class.

Depends on D3465

Test Plan

Tests will fail until swh-model 0.5.0 is tagged.

Diff Detail

Repository

rDWAPPS Web applications

Branch

swhid-to-dict-fix

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13505
Build 20664: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 20663: arc lint + arc unit

Event Timeline

anlambert created this revision.Jul 8 2020, 4:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 8 2020, 4:46 PM

anlambert mentioned this in D3465: identifiers: Add to_dict method to SWHID class.Jul 8 2020, 4:47 PM

Build has FAILED

Patch application report for D3467 (id=12266)

Rebasing onto 423ac84653...

Current branch diff-target is up to date.

Changes applied before test

commit 970bd672e60fdd34031ed8510b7a2e2f96ff2b55
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jul 8 16:45:02 2020 +0200

    api/identifiers: Adapt to swh-model >= 0.5.0
    
    SWHID is not a namedtuple anymore but a class.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/268/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/268/console

Harbormaster failed remote builds in B13486: Diff 12266!Jul 8 2020, 4:47 PM

ardumont accepted this revision.Jul 8 2020, 5:04 PM

This revision is now accepted and ready to land.Jul 8 2020, 5:04 PM

Build has FAILED

Patch application report for D3467 (id=12266)

Rebasing onto 423ac84653...

Current branch diff-target is up to date.

Changes applied before test

commit 970bd672e60fdd34031ed8510b7a2e2f96ff2b55
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jul 8 16:45:02 2020 +0200

    api/identifiers: Adapt to swh-model >= 0.5.0
    
    SWHID is not a namedtuple anymore but a class.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/269/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/269/console

Rebase

Build is green

Patch application report for D3467 (id=12286)

Rebasing onto 0af42367cd...

Current branch diff-target is up to date.

Changes applied before test

commit 2a91164b696d9f30d94c96b1520a8f66b2025b6c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jul 8 16:45:02 2020 +0200

    api/identifiers: Adapt to swh-model >= 0.5.0
    
    SWHID is not a namedtuple anymore but a class.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/271/ for more details.

Harbormaster completed remote builds in B13505: Diff 12286.Jul 8 2020, 7:16 PM

Closed by commit rDWAPPS2a91164b696d: api/identifiers: Adapt to swh-model >= 0.5.0 (authored by anlambert). · Explain WhyJul 8 2020, 7:17 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS2a91164b696d: api/identifiers: Adapt to swh-model >= 0.5.0.