Differential D3448

mercurial.loader: Refactor remaining tests to use pytest
ClosedPublic
Actions

Authored by ardumont on Jul 7 2020, 3:58 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T2487: Migrate hg loader tests code to pytest

Commits

rDLDHG56b3a8812c9e: Refactor remaining tests to use pytest

Summary

This did not touch any tests data. This now loads the loader fully through
a pg-storage instance.

This stops using the BaseLoaderTest from swh.loader.core.

(coverage remained the same 82%)

Related to T2487

Test Plan

tox

Diff Detail

Repository

rDLDHG Mercurial loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Jul 7 2020, 3:58 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 7 2020, 3:58 PM

Build is green

Patch application report for D3448 (id=12215)

Rebasing onto 2308eca5f5...

Current branch diff-target is up to date.

Changes applied before test

commit 9e3a4b31015c7767c588dfba7683ec4d30b0f856
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jul 7 15:55:53 2020 +0200

    Refactor remaining tests to use pytest
    
    Related to T2487

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/20/ for more details.

Harbormaster completed remote builds in B13435: Diff 12215.Jul 7 2020, 3:59 PM

Improve test docstring
Move assertions together
Add more checks
Drop obsolete call to origin_get (with type!)

ardumont added a subscriber: vlorentz.Jul 7 2020, 4:09 PM

ardumont added inline comments.

swh/loader/mercurial/tests/conftest.py
45	@vlorentz I forgot to update it in the prior diff [1] but see, it's here ;) [1] D3440#inline-23794
swh/loader/mercurial/tests/test_loader.py
210	I don't recall exactly what exactly was the bug about but that's the scenario to ensure we don't fail on it again [1] [1] https://www.mercurial-scm.org/wiki/TransplantExtension

Build is green

Patch application report for D3448 (id=12219)

Rebasing onto 2308eca5f5...

Current branch diff-target is up to date.

Changes applied before test

commit 56b3a8812c9e77a711cca1e8cca6426845fabba7
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jul 7 15:55:53 2020 +0200

    Refactor remaining tests to use pytest
    
    Related to T2487

See https://jenkins.softwareheritage.org/job/DLDHG/job/tests-on-diff/21/ for more details.

Harbormaster completed remote builds in B13439: Diff 12219.Jul 7 2020, 4:10 PM

ardumont edited the summary of this revision. (Show Details)Jul 7 2020, 4:12 PM

ardumont mentioned this in D3435: Add mercurial.from_disk.HgLoaderFromDisk.Jul 7 2020, 4:16 PM

ardumont edited the summary of this revision. (Show Details)Jul 7 2020, 4:21 PM