Page MenuHomeSoftware Heritage

Implement ImmutableDict.__hash__.
ClosedPublic

Authored by vlorentz on Jul 7 2020, 3:11 PM.

Diff Detail

Repository
rDMOD Data model
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D3446 (id=12211)

Could not rebase; Attempt merge onto 9e475a702a...

Updating 9e475a7..06837d5
Fast-forward
 swh/model/collections.py            | 12 +++++++++++-
 swh/model/tests/test_collections.py | 36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 47 insertions(+), 1 deletion(-)
Changes applied before test
commit 06837d5c877c6d06fc0fef193b80b1e2dc76691b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jul 7 15:10:53 2020 +0200

    Implement ImmutableDict.__hash__.

commit c4dad17f223d2300c7db187807ed74603a0e2002
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jul 7 15:04:54 2020 +0200

    Allow passing an ImmutableDict as argument to ImmutableDict's constructor.
    
    It allows easy conversion of Union[ImmutableDict, Dict] to ImmutableDict.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/118/ for more details.

This revision is now accepted and ready to land.Jul 7 2020, 3:39 PM
This revision was automatically updated to reflect the committed changes.