Differential D3445

Allow passing an ImmutableDict as argument to ImmutableDict's constructor.
ClosedPublic
Actions

Authored by vlorentz on Jul 7 2020, 3:05 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDMODc4dad17f223d: Allow passing an ImmutableDict as argument to ImmutableDict's constructor.

Summary

It allows easy conversion of Union[ImmutableDict, Dict] to ImmutableDict.

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 7 2020, 3:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 7 2020, 3:05 PM

Build is green

Patch application report for D3445 (id=12210)

Rebasing onto 9e475a702a...

Current branch diff-target is up to date.

Changes applied before test

commit c4dad17f223d2300c7db187807ed74603a0e2002
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jul 7 15:04:54 2020 +0200

    Allow passing an ImmutableDict as argument to ImmutableDict's constructor.
    
    It allows easy conversion of Union[ImmutableDict, Dict] to ImmutableDict.

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/117/ for more details.

Harbormaster completed remote builds in B13430: Diff 12210.Jul 7 2020, 3:06 PM

vlorentz added a child revision: D3447: Make SWHID immutable and hashable..Jul 7 2020, 3:13 PM

anlambert accepted this revision.Jul 7 2020, 3:40 PM

This revision is now accepted and ready to land.Jul 7 2020, 3:40 PM

Closed by commit rDMODc4dad17f223d: Allow passing an ImmutableDict as argument to ImmutableDict's constructor. (authored by vlorentz). · Explain WhyJul 7 2020, 4:03 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDMODc4dad17f223d: Allow passing an ImmutableDict as argument to ImmutableDict's constructor..