Page MenuHomeSoftware Heritage
Differential D3429

assets/save: Try to set origin type when clicking on "Save again"
ClosedPublic
Actions

Authored by anlambert on Jul 6 2020, 2:33 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T2475: Save again functionality: VCS type not pre-selected
Commits
rDWAPPS41f67245e546: assets/save: Try to set origin type when clicking on "Save again"
Summary

When clicking on the "Save again" button in save requests table, try to set
correct origin type from the origin url if possible.

This is useful when a user did not provide correct origin type initially.

Closes T2475

Diff Detail

Repository
rDWAPPS Web applications
Branch
save-again-fix-origin-type
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13368
Build 20433: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 20432: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.test_utils
.tox/py3/lib/python3.7/site-packages/swh/web/tests/api/test_utils.py:112: in <module> @given(release()) .tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:338: in release
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_content
.tox/py3/lib/python3.7/site-packages/swh/web/tests/api/views/test_content.py:16: in <module> @given(content()) .tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:88: in content
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_directory
.tox/py3/lib/python3.7/site-packages/swh/web/tests/api/views/test_directory.py:16: in <module> @given(directory()) .tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:211: in directory
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_identifiers
.tox/py3/lib/python3.7/site-packages/swh/web/tests/api/views/test_identifiers.py:27: in <module> @given(origin(), content(), directory(), release(), revision(), snapshot()) .tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:257: in origin
0 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_origin
.tox/py3/lib/python3.7/site-packages/swh/web/tests/api/views/test_origin.py:344: in <module> @given(origin()) .tox/py3/lib/python3.7/site-packages/swh/web/tests/strategies.py:257: in origin
View Full Test Results (19 Failed)

Event Timeline

anlambert created this revision.Jul 6 2020, 2:33 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 6 2020, 2:33 PM
swh-public-ci added a comment.Jul 6 2020, 2:37 PM

Build has FAILED

Patch application report for D3429 (id=12146)

Rebasing onto 423ac84653...

Current branch diff-target is up to date.
Changes applied before test
commit 1655aee9b8a4a93ef137a7f15b1ba14035fdd940
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Jul 6 14:30:28 2020 +0200

    assets/save: Try to set origin type when clicking on "Save again"
    
    When clicking on the "Save again" button in save requests table, try to set
    correct origin type from the origin url if possible.
    
    This is useful when a user did not provide correct origin type initially.
    
    Closes T2475

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/267/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/267/console

Harbormaster failed remote builds in B13368: Diff 12146!Jul 6 2020, 2:37 PM
ardumont accepted this revision.Jul 6 2020, 4:11 PM
ardumont added a subscriber: ardumont.

Looks good.

This revision is now accepted and ready to land.Jul 6 2020, 4:11 PM
anlambert updated this revision to Diff 12288.Jul 8 2020, 7:18 PM

Rebase

swh-public-ci added a comment.Jul 8 2020, 7:30 PM

Build has FAILED

Patch application report for D3429 (id=12288)

Rebasing onto 2a91164b69...

Current branch diff-target is up to date.
Changes applied before test
commit dfd9237835311c780949e19cd26fbe24f996aa11
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Jul 6 14:30:28 2020 +0200

    assets/save: Try to set origin type when clicking on "Save again"
    
    When clicking on the "Save again" button in save requests table, try to set
    correct origin type from the origin url if possible.
    
    This is useful when a user did not provide correct origin type initially.
    
    Closes T2475

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/272/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/272/console

Harbormaster failed remote builds in B13507: Diff 12288!Jul 8 2020, 7:30 PM
anlambert updated this revision to Diff 12303.Jul 9 2020, 2:45 PM

Update: Fix cypress test

swh-public-ci added a comment.Jul 9 2020, 2:57 PM

Build has FAILED

Patch application report for D3429 (id=12303)

Rebasing onto 2a91164b69...

Current branch diff-target is up to date.
Changes applied before test
commit 45402174a3f30e4fb08256858fe7e9213520285d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Jul 6 14:30:28 2020 +0200

    assets/save: Try to set origin type when clicking on "Save again"
    
    When clicking on the "Save again" button in save requests table, try to set
    correct origin type from the origin url if possible.
    
    This is useful when a user did not provide correct origin type initially.
    
    Closes T2475

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/273/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/273/console

Harbormaster failed remote builds in B13522: Diff 12303!Jul 9 2020, 2:57 PM
anlambert updated this revision to Diff 12307.Jul 9 2020, 3:45 PM

Update: Really fix cypress test

swh-public-ci added a comment.Jul 9 2020, 3:56 PM

Build is green

Patch application report for D3429 (id=12307)

Rebasing onto 2a91164b69...

Current branch diff-target is up to date.
Changes applied before test
commit 41f67245e54648b68b319aadcf336f75656fc64d
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon Jul 6 14:30:28 2020 +0200

    assets/save: Try to set origin type when clicking on "Save again"
    
    When clicking on the "Save again" button in save requests table, try to set
    correct origin type from the origin url if possible.
    
    This is useful when a user did not provide correct origin type initially.
    
    Closes T2475

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/274/ for more details.

Harbormaster completed remote builds in B13526: Diff 12307.Jul 9 2020, 3:56 PM
Closed by commit rDWAPPS41f67245e546: assets/save: Try to set origin type when clicking on "Save again" (authored by anlambert). · Explain WhyJul 9 2020, 3:58 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS41f67245e546: assets/save: Try to set origin type when clicking on "Save again".

Revision Contents
Changeset List

PathSize
cypress/
integration/
33 lines
swh/
web/
assets/
src/
bundles/
save/
14 lines

Diff 12146

View Options

cypress/integration/origin-save.spec.js

Loading...
View Options

swh/web/assets/src/bundles/save/index.js

Loading...
About · Developer information · Legal