Page MenuHomeSoftware Heritage

templates/vault-create-tasks: Improve cooking request submission UX
ClosedPublic

Authored by anlambert on Wed, Jun 24, 3:23 PM.

Details

Summary

Instead of visiting the Downloads page each time a cooking request is submitted
simply display an HTML alert at the botom left of the viewport indicating
vault task creation success.

Use the same reporting system to display vault service related errors.

Below is a screenshot of the result:

Closes T2321

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Wed, Jun 24, 3:23 PM

Build is green

Patch application report for D3347 (id=11865)

Could not rebase; Attempt merge onto 25abbb1cfd...

Updating 25abbb1c..835cfef3
Fast-forward
 cypress/integration/vault.spec.js                  | 265 ++++++++++++++-------
 .../assets/src/bundles/vault/vault-create-tasks.js |  44 +++-
 swh/web/assets/src/bundles/vault/vault-ui.js       |  93 +++++---
 swh/web/assets/src/utils/functions.js              |   1 +
 swh/web/templates/browse/vault-ui.html             |   7 +-
 swh/web/templates/includes/vault-create-tasks.html |  22 --
 6 files changed, 283 insertions(+), 149 deletions(-)
Changes applied before test
commit 835cfef38ca2afc01497b936e91d8abeec552276
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jun 24 14:26:11 2020 +0200

    templates/vault-create-tasks: Improve cooking request submission UX
    
    Instead of visiting the Downloads page each time a cooking request is submitted
    simply display an HTML alert at the botom left of the viewport indicating
    vault task creation success.
    
    Use the same reporting system to display vault service related errors.
    
    Closes T2321

commit 480f5a83415e3b83b3edb0090ebe863593b07a5c
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jun 24 11:40:58 2020 +0200

    templates/vault-ui: Update links in downloads table
    
    Add a link to browse the origin where a cooked object was found.
    
    Update link to browse the cooked object: use SWHID with context URL.
    
    Display cooked directory path if available.
    
    Wrap some long lines in vault related Javascript code.
    
    Closes T2323

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/220/ for more details.

ardumont accepted this revision.Thu, Jun 25, 10:52 AM
ardumont added a subscriber: ardumont.

Looks pretty neat :)

1 remark above.

swh/web/assets/src/utils/functions.js
11 ↗(On Diff #11865)

is that intended?

This revision is now accepted and ready to land.Thu, Jun 25, 10:52 AM
anlambert added inline comments.Thu, Jun 25, 10:55 AM
swh/web/assets/src/utils/functions.js
11 ↗(On Diff #11865)

Woops, I forgot to remove a debug output ;-) Thanks !

anlambert updated this revision to Diff 11882.Thu, Jun 25, 10:58 AM

Update: Remove debug output

Build is green

Patch application report for D3347 (id=11882)

Rebasing onto 480f5a8341...

Current branch diff-target is up to date.
Changes applied before test
commit 48874d558e7d3a7d60ef126c8c4f80edfaf45a28
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Wed Jun 24 14:26:11 2020 +0200

    templates/vault-create-tasks: Improve cooking request submission UX
    
    Instead of visiting the Downloads page each time a cooking request is submitted
    simply display an HTML alert at the botom left of the viewport indicating
    vault task creation success.
    
    Use the same reporting system to display vault service related errors.
    
    Closes T2321

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/222/ for more details.