Differential D3193

db: Use query_params instead of mogrify
ClosedPublic
Actions

Authored by ardumont on May 28 2020, 1:33 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDSTO738d6489bc19: db: Use query_params instead of mogrify

Summary

Related to D3180

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 12536
Build 19042: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 19041: arc lint + arc unit

Event Timeline

ardumont created this revision.May 28 2020, 1:33 PM

ardumont mentioned this in D3180: pg: Write origin visit updates & status, read from origin_visit_status.May 28 2020, 1:34 PM

Build is green

Patch application report for D3193 (id=11343)

Rebasing onto cada7fc5de...

Current branch diff-target is up to date.

Changes applied before test

commit 738d6489bc194f032b0f6c82a34285d785298e82
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu May 28 13:32:16 2020 +0200

    db: Use query_params instead of mogrify
    
    Related to D3180

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/202/ for more details.

Harbormaster completed remote builds in B12536: Diff 11343.May 28 2020, 1:40 PM

That's my cue ;)

13:34 <+ardumont> olasd: is that what you had in mind D3193?
13:34 -- Notice(swhbot): D3193 (author: ardumont, Needs Review) on swh-storage: db: Use query_params instead of mogrify <https://forge.softwareheritage.org/D3193>
13:35 <vlorentz> ardumont: lgtm
13:36 <+ardumont> \o/
13:38 <+olasd> ardumont: yes, exactly
13:39 <+ardumont> cool, thanks both

This revision was not accepted when it landed; it landed in state Needs Review.May 28 2020, 1:42 PM

Closed by commit rDSTO738d6489bc19: db: Use query_params instead of mogrify (authored by ardumont). · Explain Why

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO738d6489bc19: db: Use query_params instead of mogrify.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

storage/

db.py

13 lines

95%

Diff 11343

View Options

db: Use query_params instead of mogrifyClosedPublicActions