Page MenuHomeSoftware Heritage

templates/content-display: Fix view when an image cannot be rendered
ClosedPublic

Authored by anlambert on May 4 2020, 4:31 PM.

Details

Summary

Previously, a suprising "Error 200" was displayed in place of a message indicating
that the file cannot be rendered.

Also simplify some code in swh.web.tests.data module.

Closes T2389

Diff Detail

Repository
rDWAPPS Web applications
Branch
fix-unsupported-image-rendering-content-view
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12247
Build 18575: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 18574: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D3118 (id=11078)

Rebasing onto 3cdfd8a039...

Current branch diff-target is up to date.
Changes applied before test
commit 97c8291f0bb3e69e6ec08aa18942c42f1eef2963
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon May 4 16:21:55 2020 +0200

    templates/content-display: Fix view when an image cannot be rendered
    
    Previously, a suprising "Error 200" was displayed in place of a message indicating
    that the file cannot be rendered.
    
    Also simplify some code in swh.web.tests.data module.
    
    Closes T2389

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/114/ for more details.

This revision is now accepted and ready to land.May 4 2020, 5:55 PM