Differential D3118

templates/content-display: Fix view when an image cannot be rendered
ClosedPublic
Actions

Authored by anlambert on May 4 2020, 4:31 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2389: "Error 200" when browsing a .psd file

Commits

rDWAPPS97c8291f0bb3: templates/content-display: Fix view when an image cannot be rendered

Summary

Previously, a suprising "Error 200" was displayed in place of a message indicating
that the file cannot be rendered.

Also simplify some code in swh.web.tests.data module.

Closes T2389

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.May 4 2020, 4:31 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 4 2020, 4:31 PM

Build is green

Patch application report for D3118 (id=11078)

Rebasing onto 3cdfd8a039...

Current branch diff-target is up to date.

Changes applied before test

commit 97c8291f0bb3e69e6ec08aa18942c42f1eef2963
Author: Antoine Lambert <antoine.lambert@inria.fr>
Date:   Mon May 4 16:21:55 2020 +0200

    templates/content-display: Fix view when an image cannot be rendered
    
    Previously, a suprising "Error 200" was displayed in place of a message indicating
    that the file cannot be rendered.
    
    Also simplify some code in swh.web.tests.data module.
    
    Closes T2389

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/114/ for more details.

Harbormaster completed remote builds in B12247: Diff 11078.May 4 2020, 4:41 PM

vlorentz accepted this revision.May 4 2020, 5:55 PM

This revision is now accepted and ready to land.May 4 2020, 5:55 PM

Closed by commit rDWAPPS97c8291f0bb3: templates/content-display: Fix view when an image cannot be rendered (authored by anlambert). · Explain WhyMay 4 2020, 6:25 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS97c8291f0bb3: templates/content-display: Fix view when an image cannot be rendered.