Page MenuHomeSoftware Heritage

Consistently use TargetType, instead of mixing it with strings.
ClosedPublic

Authored by vlorentz on Apr 1 2020, 3:25 PM.

Diff Detail

Repository
rDLDG Git loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11556
Build 17518: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 17517: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D2940 (id=10462)

Rebasing onto a600855a12...

Current branch diff-target is up to date.
Changes applied before test
commit b708a4c5c636d9832cacb571399c4f35f72c303f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 1 15:25:09 2020 +0200

    Consistently use TargetType, instead of mixing it with strings.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/2/ for more details.

don't use a local function

Build is green

Patch application report for D2940 (id=10463)

Rebasing onto a600855a12...

Current branch diff-target is up to date.
Changes applied before test
commit 387d30159eabfbf60ab7d1456b55858a14179cf4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 1 15:25:09 2020 +0200

    Consistently use TargetType, instead of mixing it with strings.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/3/ for more details.

This revision is now accepted and ready to land.Apr 1 2020, 3:38 PM
ardumont added a subscriber: ardumont.

When the storage returns us some model objects (from read endpoints), we may no longer need those adaptations ;)