Consistently use TargetType, instead of mixing it with strings.
ClosedPublic
Actions

Authored by vlorentz on Apr 1 2020, 3:25 PM.

Details

Reviewers

douardda
ardumont

Group Reviewers

Reviewers

Commits

rDLDG387d30159eab: Consistently use TargetType, instead of mixing it with strings.

Summary

Replaces D2918.

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 1 2020, 3:25 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 1 2020, 3:25 PM

Build is green

Patch application report for D2940 (id=10462)

Rebasing onto a600855a12...

Current branch diff-target is up to date.

Changes applied before test

commit b708a4c5c636d9832cacb571399c4f35f72c303f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 1 15:25:09 2020 +0200

    Consistently use TargetType, instead of mixing it with strings.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/2/ for more details.

Harbormaster completed remote builds in B11555: Diff 10462.Apr 1 2020, 3:27 PM

don't use a local function

Build is green

Patch application report for D2940 (id=10463)

Rebasing onto a600855a12...

Current branch diff-target is up to date.

Changes applied before test

commit 387d30159eabfbf60ab7d1456b55858a14179cf4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 1 15:25:09 2020 +0200

    Consistently use TargetType, instead of mixing it with strings.

See https://jenkins.softwareheritage.org/job/DLDG/job/tests-on-diff/3/ for more details.

Harbormaster completed remote builds in B11556: Diff 10463.Apr 1 2020, 3:36 PM

douardda accepted this revision.Apr 1 2020, 3:38 PM

This revision is now accepted and ready to land.Apr 1 2020, 3:38 PM

douardda mentioned this in D2918: GitLoader: instantiate SnapshotBranch object using the from_dict factory.Apr 1 2020, 3:38 PM