GitLoader: instantiate SnapshotBranch object using the from_dict factory
AbandonedPublic
Actions

Authored by douardda on Mar 27 2020, 4:36 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Summary

rather than direct instantiation to ensure proper type conversion of the
target_type argument.

Depends on D2917.

Diff Detail

Repository

rDLDG Git loader

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 11431
Build 17317: tox-on-jenkins	Jenkins
Build 17316: arc lint + arc unit

Event Timeline

douardda created this revision.Mar 27 2020, 4:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 27 2020, 4:36 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/120/ for more details.

Harbormaster completed remote builds in B11431: Diff 10352.Mar 27 2020, 4:40 PM

DULWICH_TARGET_TYPES are already the right enum values.

This revision now requires changes to proceed.Mar 27 2020, 5:01 PM

In D2918#70261, @vlorentz wrote:

DULWICH_TARGET_TYPES are already the right enum values.

Dunno, but without this and running against next swh.model version (with runtime type validation) I have a

AttributeTypeError: target_type must be <enum 'TargetType'> (got revision that is a <class 'str'>)

What about this instead?

self.local_refs: Dict[bytes, Dict[str, Any]] = fetch_info['local_refs']

or just # type: ignore on this line until I fix self.local_refs

vlorentz mentioned this in D2940: Consistently use TargetType, instead of mixing it with strings..Apr 1 2020, 3:25 PM

see D2940

Revision Contents
Changeset List

Path

Size

swh/

loader/

git/

loader.py

4 lines

Diff 10352

View Options

GitLoader: instantiate SnapshotBranch object using the from_dict factoryAbandonedPublicActions