Differential D2917

converters: fix types of TimestampWithTimezone arguments
ClosedPublic
Actions

Authored by douardda on Mar 27 2020, 4:36 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLDGa600855a1234: converters: fix types of TimestampWithTimezone arguments

Summary

and other arguments in test_converters.py to match model's descriptions.

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Mar 27 2020, 4:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 27 2020, 4:36 PM

douardda added a child revision: D2918: GitLoader: instantiate SnapshotBranch object using the from_dict factory.Mar 27 2020, 4:36 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/119/ for more details.

Harbormaster completed remote builds in B11430: Diff 10351.Mar 27 2020, 4:38 PM

vlorentz accepted this revision.Mar 27 2020, 5:00 PM

This revision is now accepted and ready to land.Mar 27 2020, 5:00 PM

Closed by commit rDLDGa600855a1234: converters: fix types of TimestampWithTimezone arguments (authored by douardda). · Explain WhyMar 30 2020, 5:27 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDLDGa600855a1234: converters: fix types of TimestampWithTimezone arguments.

Revision Contents
Changeset List

Path

Size

swh/

loader/

git/

converters.py

4 lines

tests/

test_converters.py

16 lines

Diff 10396

View Options

swh/loader/git/converters.py