Page MenuHomeSoftware Heritage

core.loader: Allow core loader to update origin_visit in one call
ClosedPublic

Authored by ardumont on Thu, Mar 26, 3:30 PM.

Details

Summary

Prior to this commit, subclasses were in charge of setting the snapshot (for an
origin_visit).

There ended up being 2 origin_visit_update calls, 1 in the subclass to set
the snapshot id, then 1 in the loader core to set the visit (e.g. svn loader)

Motivation:
Make the origin_visit_update status parameter mandatory.

Preparatory work for T2310

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Thu, Mar 26, 3:30 PM
vlorentz accepted this revision.Thu, Mar 26, 3:32 PM
This revision is now accepted and ready to land.Thu, Mar 26, 3:32 PM
ardumont updated this revision to Diff 10281.Thu, Mar 26, 3:35 PM

Rebase on latest master