Page MenuHomeSoftware Heritage
Differential D2888

svn.loader: Let core loader update snapshot & visit at the same time
ClosedPublic
Actions

Authored by ardumont on Mar 26 2020, 3:31 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDLDSVN836eb0093f02: svn.loader: Let core loader update snapshot & visit at the same time
Summary

Prior to this commit, the loader svn did an origin visit update to set the
snapshot. And then the loader core did the update to set the status.

This removes the origin visit update on the snapshot to let the loader core do
everything.

Related to D2887

Test Plan

tox

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 26 2020, 3:31 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 26 2020, 3:31 PM
swh-public-ci added a comment.Mar 26 2020, 3:33 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/78/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/78/console

Harbormaster failed remote builds in B11359: Diff 10280!Mar 26 2020, 3:33 PM
ardumont updated this revision to Diff 10282.Mar 26 2020, 3:37 PM

Fix requirements-swh.txt to the right loader-core version

swh-public-ci added a comment.Mar 26 2020, 3:38 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/79/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/79/console

Harbormaster failed remote builds in B11361: Diff 10282!Mar 26 2020, 3:38 PM
swh-public-ci added a comment.Mar 26 2020, 3:46 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/80/ for more details.

Harbormaster completed remote builds in B11361: Diff 10282.Mar 26 2020, 3:46 PM
ardumont edited the summary of this revision. (Show Details)Mar 26 2020, 3:53 PM
vlorentz accepted this revision.Mar 26 2020, 3:54 PM
This revision is now accepted and ready to land.Mar 26 2020, 3:54 PM
Closed by commit rDLDSVN836eb0093f02: svn.loader: Let core loader update snapshot & visit at the same time (authored by ardumont). · Explain WhyMar 26 2020, 4:03 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDSVN836eb0093f02: svn.loader: Let core loader update snapshot & visit at the same time.
vlorentz mentioned this in T2310: Make origin visits immutable.Mar 26 2020, 4:54 PM
ardumont mentioned this in D2893: storage*: Update origin_visit_update to make status parameter mandatory.Mar 26 2020, 5:15 PM
ardumont mentioned this in D2941: docs/data-model: Update visits chapter definition.Apr 2 2020, 11:49 AM
ardumont mentioned this in D3204: Use loader_snapshot_id from swh.loader.core 0.1.0 instead of get_snapshot_id.May 29 2020, 5:31 PM

Revision Contents
Changeset List

PathSize
2 lines
swh/
loader/
svn/
13 lines

Diff 10285

View Options

requirements-swh.txt

Loading...
View Options

swh/loader/svn/loader.py

Loading...
About · Developer information · Legal