Differential D2883

test: Adapt origin validation test according to latest model changes
ClosedPublic
Actions

Authored by ardumont on Mar 26 2020, 10:58 AM.

Tags

None

Subscribers

None

Details

Reviewers

vlorentz
douardda

Group Reviewers

Commits

rDSTO40a7569e986f: test: Adapt origin validation test according to latest model changes

Summary

Origin model no longer allows to have a type.

Test will work if the new swh.model is tagged (and successfully uploaded to pypi)

Related to f533f62bbf114cfcc29f7c72307c4dfbe99cf048

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 26 2020, 10:58 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1087/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1087/console

Harbormaster failed remote builds in B11344: Diff 10266!Mar 26 2020, 10:59 AM

It tests for the missing url, so it's still relevant.

This revision now requires changes to proceed.Mar 26 2020, 11:00 AM

Fix properly the test

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1088/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1088/console

Harbormaster failed remote builds in B11347: Diff 10268!Mar 26 2020, 11:09 AM

vlorentz accepted this revision.Mar 26 2020, 11:12 AM

This revision is now accepted and ready to land.Mar 26 2020, 11:12 AM

ardumont edited the summary of this revision. (Show Details)Mar 26 2020, 11:17 AM

Add docstring to test

(Test will fail because swh.model upload to pypi is failing for now)

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1089/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1089/console

Harbormaster failed remote builds in B11348: Diff 10269!Mar 26 2020, 11:19 AM

ardumont mentioned this in D2879: storage: Refactor internal implementations to use "origin visit update" model representation.Mar 26 2020, 11:20 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1092/ for more details.

ardumont retitled this revision from test_storage: Remove no longer relevant validation test to test: Adapt origin validation test according to latest model changes.Mar 26 2020, 3:41 PM

Rebase to latest master

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1093/ for more details.

Harbormaster completed remote builds in B11348: Diff 10269.Mar 26 2020, 3:46 PM

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1095/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1095/console

Harbormaster failed remote builds in B11363: Diff 10284!Mar 26 2020, 4:03 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1096/ for more details.

Harbormaster completed remote builds in B11363: Diff 10284.Mar 26 2020, 4:10 PM

Closed by commit rDSTO40a7569e986f: test: Adapt origin validation test according to latest model changes (authored by ardumont). · Explain WhyMar 26 2020, 4:16 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSTO40a7569e986f: test: Adapt origin validation test according to latest model changes.

ardumont mentioned this in D2898: (ci: fix master build) journal.tests: Adapt model according to latest change.Mar 27 2020, 7:35 AM

Revision Contents
Changeset List

Path

Size

requirements-swh.txt

2 lines

swh/

storage/

tests/

test_storage.py

8 lines

Diff 10288

requirements-swh.txt

Loading...

swh/storage/tests/test_storage.py

Loading...