Differential D2729

Use origin_visit_get_latest instead of snapshot_get_latest.
ClosedPublic
Actions

Authored by vlorentz on Feb 28 2020, 1:34 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDGf2a0736f42e9: Use origin_visit_get_latest instead of snapshot_get_latest.

Summary

snapshot_get_latest is deprecated, and one of the call didn't need
to get the branches at all, only the id.

Diff Detail

Repository

rDLDG Git loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 28 2020, 1:34 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 28 2020, 1:34 PM

ardumont accepted this revision.Feb 28 2020, 1:39 PM

This revision is now accepted and ready to land.Feb 28 2020, 1:39 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDG/job/tox/112/ for more details.

Harbormaster completed remote builds in B10801: Diff 9734.Feb 28 2020, 1:40 PM

vlorentz added a child revision: D2731: Use swh-model objects instead of dicts..Feb 28 2020, 5:24 PM

Closed by commit rDLDGf2a0736f42e9: Use origin_visit_get_latest instead of snapshot_get_latest. (authored by vlorentz). · Explain WhyFeb 28 2020, 5:30 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDGf2a0736f42e9: Use origin_visit_get_latest instead of snapshot_get_latest..

ardumont mentioned this in D3301: origin_head: Retrieve snapshot out of the last visit status.Jun 17 2020, 12:19 PM

Revision Contents
Changeset List

Path

Size

swh/

loader/

git/

from_disk.py

13 lines

loader.py

12 lines

Diff 9754

View Options

swh/loader/git/from_disk.py