Page MenuHomeSoftware Heritage

origin_head: Retrieve snapshot out of the last visit status
ClosedPublic

Authored by ardumont on Wed, Jun 17, 11:56 AM.

Details

Summary

Related to T2310

Depends on D3313

Test Plan

tox

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Wed, Jun 17, 11:56 AM

Build is green

Patch application report for D3301 (id=11697)

Rebasing onto 3f4c534922...

Current branch diff-target is up to date.
Changes applied before test
commit dab0dc837b6a93cd57d9f10a7c909e19677f0bdd
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 17 11:51:35 2020 +0200

    origin_head: Retrieve the latest snapshot directly
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/14/ for more details.

ardumont planned changes to this revision.Wed, Jun 17, 12:19 PM

snapshot_get_latest is deprecated (not marked in the storage though so i did not see)
So i need to change this.

Related to D2729
Related to D1581

ardumont updated this revision to Diff 11709.Wed, Jun 17, 4:25 PM

Use origin_visit_status_get_latest instead of snapshot_get_latest (as it's
deprecated as mentioned earlier here)

Build is green

Patch application report for D3301 (id=11709)

Rebasing onto 3f4c534922...

Current branch diff-target is up to date.
Changes applied before test
commit 372a41c4c76ab057ca49b04ec92564c2e0de2541
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 17 11:51:35 2020 +0200

    origin_head: Retrieve the latest snapshot directly
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/15/ for more details.

ardumont retitled this revision from origin_head: Retrieve the latest snapshot directly to origin_head: Retrieve snapshot out of the last visit status.Wed, Jun 17, 4:28 PM
ardumont updated this revision to Diff 11712.Wed, Jun 17, 4:40 PM

Rework commit message (align with diff description)

Build is green

Patch application report for D3301 (id=11712)

Rebasing onto 3f4c534922...

Current branch diff-target is up to date.
Changes applied before test
commit 931f25cca26e97bf1f52a545e37355d09e8b2976
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 17 11:51:35 2020 +0200

    origin_head: Retrieve snapshot out of the last visit status
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/16/ for more details.

ardumont planned changes to this revision.Thu, Jun 18, 7:48 AM
ardumont updated this revision to Diff 11734.Thu, Jun 18, 3:51 PM

Adapt according to latest storage development

Depends on D3313

(expects the tests to fail as storage is not tagged yet)

Build has FAILED

Patch application report for D3301 (id=11734)

Rebasing onto 3f4c534922...

Current branch diff-target is up to date.
Changes applied before test
commit a8307fccb4af4aad534bd694c8d4e3e59fc5a188
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 17 11:51:35 2020 +0200

    origin_head: Retrieve snapshot out of the last visit status
    
    Related to T2310

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/17/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/17/console

ardumont edited the test plan for this revision. (Show Details)Thu, Jun 18, 3:55 PM

Build is green

Patch application report for D3301 (id=11734)

Rebasing onto 3f4c534922...

Current branch diff-target is up to date.
Changes applied before test
commit a8307fccb4af4aad534bd694c8d4e3e59fc5a188
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Jun 17 11:51:35 2020 +0200

    origin_head: Retrieve snapshot out of the last visit status
    
    Related to T2310

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/18/ for more details.

ardumont edited the test plan for this revision. (Show Details)Fri, Jun 19, 1:05 PM
vlorentz accepted this revision.Fri, Jun 19, 3:34 PM
This revision is now accepted and ready to land.Fri, Jun 19, 3:34 PM