Make create_task_type idempotent
ClosedPublic
Actions

Authored by anlambert on Feb 17 2020, 4:56 PM.

Details

Reviewers

vlorentz
olasd

Group Reviewers

Reviewers

Commits

rDSCHaf58466e6ec3: backend: Make create_task_type idempotent

Summary

There is no reason to raise an error when a task type has already been created and it enables to stop leaking
psycopg2 IntegrityError exception as part of the scheduler interface.

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

fix-api-client-test

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10638
Build 15938: tox-on-jenkins	Jenkins
Build 15937: arc lint + arc unit

Event Timeline

anlambert created this revision.Feb 17 2020, 4:56 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/348/ for more details.

Harbormaster completed remote builds in B10638: Diff 9579.Feb 17 2020, 5:03 PM

Instead of doing this, I think we should really make create_task_type idempotent. Looks like no users of this API actually depend on the "fail if type already exists" behavior.

If we do that, we'll stop leaking psycopg2 IntegrityErrors as part of the scheduler interface, which is, er, gross.

This revision now requires changes to proceed.Feb 18 2020, 2:54 PM

In D2683#64235, @olasd wrote:

Instead of doing this, I think we should really make create_task_type idempotent. Looks like no users of this API actually depend on the "fail if type already exists" behavior.

If we do that, we'll stop leaking psycopg2 IntegrityErrors as part of the scheduler interface, which is, er, gross.

Ack, seems better indeed.

Update: make create_task_type idempotent instead of raising an exception when a task type has already been created.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/349/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/349/console

Harbormaster failed remote builds in B10675: Diff 9614!Feb 18 2020, 3:31 PM

vlorentz added inline comments.Feb 18 2020, 4:30 PM

swh/scheduler/backend.py
103 ↗	(On Diff #9614)	Wouldn't it make more to `do update`?

anlambert added inline comments.Feb 18 2020, 4:38 PM

swh/scheduler/backend.py
103 ↗	(On Diff #9614)	Indeed, it could be used to change task type setup. But then it is no more a creation operation. @olasd, your opinion on this ?

anlambert retitled this revision from test_scheduler: Fix a RPC test after recent changes in swh-core to Make create_task_type idempotent.Feb 18 2020, 4:59 PM

anlambert edited the summary of this revision. (Show Details)

Build is green
See https://jenkins.softwareheritage.org/job/DSCH/job/tox/350/ for more details.

Harbormaster completed remote builds in B10675: Diff 9614.Feb 18 2020, 5:05 PM

olasd accepted this revision.Feb 19 2020, 2:09 PM

olasd added inline comments.