Page MenuHomeSoftware Heritage
Differential D2678

Use iso8601.parse_date instead of dateutil.parser.parse.
ClosedPublic
Actions

Authored by vlorentz on Feb 14 2020, 6:21 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDCORE9667700ab536: Use iso8601.parse_date instead of dateutil.parser.parse.
Summary

iso8601 is more strict, and less inefficient.

Depends on D2675.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Branch
iso8601
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10615
Build 15877: tox-on-jenkinsJenkins
Build 15876: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 14 2020, 6:21 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 14 2020, 6:21 PM
swh-public-ci added a comment.Feb 14 2020, 6:23 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/412/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/412/console

Harbormaster failed remote builds in B10615: Diff 9554!Feb 14 2020, 6:23 PM
vlorentz planned changes to this revision.Feb 14 2020, 6:24 PM
vlorentz updated this revision to Diff 9558.Feb 14 2020, 7:36 PM

fix naive datetime support

swh-public-ci added a comment.Feb 14 2020, 7:38 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/414/ for more details.

Harbormaster completed remote builds in B10619: Diff 9558.Feb 14 2020, 7:38 PM
olasd requested changes to this revision.Feb 17 2020, 4:20 PM
olasd added a subscriber: olasd.

I think this diff has the wrong base commit.

This revision now requires changes to proceed.Feb 17 2020, 4:20 PM
vlorentz updated this revision to Diff 9585.Feb 18 2020, 11:32 AM

change base commit

olasd accepted this revision.Feb 18 2020, 11:33 AM
This revision is now accepted and ready to land.Feb 18 2020, 11:33 AM
swh-public-ci added a comment.Feb 18 2020, 11:34 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/415/ for more details.

Harbormaster completed remote builds in B10644: Diff 9585.Feb 18 2020, 11:34 AM
Closed by commit rDCORE9667700ab536: Use iso8601.parse_date instead of dateutil.parser.parse. (authored by vlorentz). · Explain WhyFeb 18 2020, 11:34 AM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDCORE9667700ab536: Use iso8601.parse_date instead of dateutil.parser.parse..

Revision Contents
Changeset List

PathSize
3 lines
2 lines
swh/
core/
api/
4 lines

Diff 9554

View Options

mypy.ini

Loading...
View Options

requirements-http.txt

Loading...
View Options

swh/core/api/serializers.py

Loading...
About · Developer information · Legal