Page MenuHomeSoftware Heritage

Change msgpack serialization to be closer to the JSON one.
ClosedPublic

Authored by vlorentz on Fri, Feb 14, 4:14 PM.

Details

Summary

This breaks the current protocol, but deduplicates the code, and will allow
for the addition of extra custom encoders/decoders by callers of this module.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Fri, Feb 14, 4:14 PM
olasd accepted this revision.Fri, Feb 14, 6:02 PM

Have you tested remote apis with these changes? They look sound, but I guess better coverage would actually come from that.

swh/core/api/serializers.py
36

I guess now that we're making a protocol break, it'd be a good time to switch over to iso8601, or at least dateutil.parser.isoparse, instead of letting ourselves parse garbage.

This revision is now accepted and ready to land.Fri, Feb 14, 6:02 PM