Page MenuHomeSoftware Heritage
Differential D2675

Add extra_type_encoders and extra_type_decoders attributes to RPC clients and servers.
ClosedPublic
Actions

Authored by vlorentz on Feb 14 2020, 5:21 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDCORE9cdc9168b264: Add extra_type_encoders and extra_type_decoders attributes to RPC clients and…
Summary

They will allow swh-storage to override them to serialize and
deserialize swh-model objects.

Depends on D2672.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 14 2020, 5:21 PM
swh-public-ci added a comment.Feb 14 2020, 5:23 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/410/ for more details.

Harbormaster completed remote builds in B10609: Diff 9548.Feb 14 2020, 5:23 PM
vlorentz updated this revision to Diff 9549.Feb 14 2020, 5:26 PM

fix type

vlorentz mentioned this in D2676: Add support for (de)serializing swh-model in RPC calls..Feb 14 2020, 5:26 PM
swh-public-ci added a comment.Feb 14 2020, 5:27 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/411/ for more details.

Harbormaster completed remote builds in B10610: Diff 9549.Feb 14 2020, 5:27 PM
vlorentz added a child revision: D2678: Use iso8601.parse_date instead of dateutil.parser.parse..Feb 14 2020, 6:21 PM
olasd requested changes to this revision.Feb 14 2020, 6:28 PM

Could you add some tests which exert these new extra_{encoder,decoder} parameters?

Even though this is going to be integration-tested by swh.storage, having a shorter feedback loop would be useful.

This revision now requires changes to proceed.Feb 14 2020, 6:28 PM
vlorentz updated this revision to Diff 9557.Feb 14 2020, 7:02 PM

add tests.

swh-public-ci added a comment.Feb 14 2020, 7:04 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/413/ for more details.

Harbormaster completed remote builds in B10618: Diff 9557.Feb 14 2020, 7:04 PM
olasd accepted this revision.Feb 17 2020, 4:18 PM
This revision is now accepted and ready to land.Feb 17 2020, 4:18 PM
Closed by commit rDCORE9cdc9168b264: Add extra_type_encoders and extra_type_decoders attributes to RPC clients and… (authored by vlorentz). · Explain WhyFeb 18 2020, 11:31 AM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDCORE9cdc9168b264: Add extra_type_encoders and extra_type_decoders attributes to RPC clients and….

Revision Contents
Changeset List

PathSize
swh/
core/
api/
80 lines
12 lines
tests/
21 lines
29 lines
6 lines

Diff 9584

View Options

swh/core/api/__init__.py

Loading...
View Options

swh/core/api/serializers.py

Loading...
View Options

swh/core/api/tests/test_rpc_client.py

Loading...
View Options

swh/core/api/tests/test_rpc_server.py

Loading...
View Options

swh/core/api/tests/test_serializers.py

Loading...
About · Developer information · Legal