Page MenuHomeSoftware Heritage

Add extra_type_encoders and extra_type_decoders attributes to RPC clients and servers.
ClosedPublic

Authored by vlorentz on Fri, Feb 14, 5:21 PM.

Details

Summary

They will allow swh-storage to override them to serialize and
deserialize swh-model objects.

Depends on D2672.

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Fri, Feb 14, 5:21 PM
vlorentz updated this revision to Diff 9549.Fri, Feb 14, 5:26 PM

fix type

olasd requested changes to this revision.Fri, Feb 14, 6:28 PM

Could you add some tests which exert these new extra_{encoder,decoder} parameters?

Even though this is going to be integration-tested by swh.storage, having a shorter feedback loop would be useful.

This revision now requires changes to proceed.Fri, Feb 14, 6:28 PM
vlorentz updated this revision to Diff 9557.Fri, Feb 14, 7:02 PM

add tests.

olasd accepted this revision.Mon, Feb 17, 4:18 PM
This revision is now accepted and ready to land.Mon, Feb 17, 4:18 PM