Page MenuHomeSoftware Heritage
Differential D2535

core.loader: Drop retry and unnecessary storage indirections
ClosedPublic
Actions

Authored by ardumont on Jan 15 2020, 3:05 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDLDBASEd527ad77b547: Drop no longer used retrying dependency
rDLDBASEaa71ed57fdd6: core.loader: Clean up indirection and retry behavior
rDLDBASE074f07843ce0: core.loaders: Drop unused counters
rDLDBASE3eb14c83743a: core.loader: Drop send_origin/send_origin_visit indirections
rDLDBASE4ad6e95faa34: core.loader.tests: Use retry proxy storage
Summary

We can now have that retry bevavior using the storage's retry
configuration.

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10124
Build 15014: tox-on-jenkinsJenkins
Build 15013: arc lint + arc unit

Event Timeline

ardumont created this revision.Jan 15 2020, 3:05 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 15 2020, 3:05 PM
swh-public-ci added a comment.Jan 15 2020, 3:06 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/312/ for more details.

Harbormaster completed remote builds in B10123: Diff 9021.Jan 15 2020, 3:06 PM
vlorentz accepted this revision.Jan 15 2020, 3:08 PM
vlorentz added a subscriber: vlorentz.

yay

This revision is now accepted and ready to land.Jan 15 2020, 3:08 PM
ardumont updated this revision to Diff 9022.Jan 15 2020, 3:11 PM

Plug to master branch

ardumont mentioned this in D2536: svn.loader: Adapt with latest loader-core simplification.Jan 15 2020, 3:12 PM
Harbormaster completed remote builds in B10124: Diff 9022.Jan 15 2020, 3:13 PM
swh-public-ci added a comment.Jan 15 2020, 3:13 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/313/ for more details.

Closed by commit rDLDBASE4ad6e95faa34: core.loader.tests: Use retry proxy storage (authored by ardumont). · Explain WhyJan 15 2020, 3:14 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDBASE4ad6e95faa34: core.loader.tests: Use retry proxy storage.
ardumont added a commit: rDLDBASE3eb14c83743a: core.loader: Drop send_origin/send_origin_visit indirections.
ardumont added a commit: rDLDBASE074f07843ce0: core.loaders: Drop unused counters.
ardumont added a commit: rDLDBASEaa71ed57fdd6: core.loader: Clean up indirection and retry behavior.
ardumont added a commit: rDLDBASEd527ad77b547: Drop no longer used retrying dependency.
ardumont mentioned this in rDLDSVN161f978a7c00: svn.loader: Adapt according to latest loader-core simplification.Jan 15 2020, 3:59 PM

Revision Contents
Changeset List

PathSize
1 line
swh/
loader/
core/
288 lines
tests/
281 lines

Diff 9022

View Options

requirements.txt

Loading...
View Options

swh/loader/core/loader.py

Loading...
View Options

swh/loader/core/tests/test_loader.py

Loading...
About · Developer information · Legal