Page MenuHomeSoftware Heritage
Differential D2514

Add env var SWH_MAIN_PACKAGE to initialize sentry_sdk with a release.
ClosedPublic
Actions

Authored by vlorentz on Jan 10 2020, 3:08 PM.

Details

Reviewers
douardda
olasd
ardumont
Group Reviewers
Reviewers
Commits
rDCORE2255767b9763: Add env var SWH_MAIN_PACKAGE to initialize sentry_sdk with a release.
Summary

Also deduplicates code used to call sentry_sdk.init by making all our
init code go through the same function swh.core.sentry.init_sentry."

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 10 2020, 3:08 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 10 2020, 3:08 PM
swh-public-ci added a comment.Jan 10 2020, 3:11 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/383/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/383/console

Harbormaster failed remote builds in B10034: Diff 8932!Jan 10 2020, 3:11 PM
vlorentz added a child revision: D2515: Use swh.core.sentry instead of calling sentry_sdk.init directly..Jan 10 2020, 3:13 PM
douardda requested changes to this revision.Jan 13 2020, 10:32 AM
douardda added a subscriber: douardda.

I'm a bit puzzled by the 2 revisions in this diff. Are they related? I don't really see how/why.

Also please consider better commit message with the 'why' (why do we need "Allow subclasses of RPCClient to override generated methods", and even if i might appear king of obvious, why do we need this SWH_MAIN_PACKAGE).

BTW there seem to be a typo in this commit message (there is a closing " without an opening one).

This revision now requires changes to proceed.Jan 13 2020, 10:32 AM
douardda added a comment.Jan 13 2020, 10:37 AM

Oh maybe it's a mixed up 'arc diff --update' (with D2515)

vlorentz updated this revision to Diff 8947.Jan 13 2020, 2:05 PM

remove unwanted commit

vlorentz retitled this revision from Allow subclasses of RPCClient to override generated methods. to Add env var SWH_MAIN_PACKAGE to initialize sentry_sdk with a release..Jan 13 2020, 2:05 PM
vlorentz edited the summary of this revision. (Show Details)

code from D2442 got mixed up with this diff. fixed

swh-public-ci added a comment.Jan 13 2020, 2:07 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/384/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/384/console

Harbormaster failed remote builds in B10050: Diff 8947!Jan 13 2020, 2:07 PM
vlorentz updated this revision to Diff 8965.Jan 14 2020, 11:56 AM

fix test

swh-public-ci added a comment.Jan 14 2020, 11:59 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/385/ for more details.

Harbormaster completed remote builds in B10066: Diff 8965.Jan 14 2020, 11:59 AM
olasd accepted this revision.Jan 14 2020, 2:40 PM
ardumont accepted this revision.Jan 15 2020, 11:09 AM
douardda accepted this revision.Jan 15 2020, 11:13 AM

I'm fine with the code, but as I already said, I'd really like the commit message to have a paragraph on why this is needed and what problem it solves.

It might be obvious for the author of the diff but not for someone with no particular knowledge in sentry reading the git log...

This revision is now accepted and ready to land.Jan 15 2020, 11:13 AM
vlorentz updated this revision to Diff 9004.Jan 15 2020, 1:06 PM

update commit message

This revision was landed with ongoing or failed builds.Jan 15 2020, 1:06 PM
Closed by commit rDCORE2255767b9763: Add env var SWH_MAIN_PACKAGE to initialize sentry_sdk with a release. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDCORE2255767b9763: Add env var SWH_MAIN_PACKAGE to initialize sentry_sdk with a release..
Harbormaster failed remote builds in B10105: Diff 9004!Jan 15 2020, 1:07 PM
swh-public-ci added a comment.Jan 15 2020, 1:07 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/386/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/386/console

vlorentz removed a child revision: D2515: Use swh.core.sentry instead of calling sentry_sdk.init directly..Jan 15 2020, 1:11 PM

Revision Contents
Changeset List

PathSize
swh/
core/
api/
34 lines
tests/
24 lines
cli/
6 lines
35 lines
tests/
34 lines

Diff 9005

View Options

swh/core/api/gunicorn_config.py

Loading...
View Options

swh/core/api/tests/test_gunicorn.py

Loading...
View Options

swh/core/cli/__init__.py

Loading...
View Options

swh/core/sentry.py

Loading...
View Options

swh/core/tests/test_cli.py

Loading...
About · Developer information · Legal