Page MenuHomeSoftware Heritage

Add env var SWH_MAIN_PACKAGE to initialize sentry_sdk with a release.
ClosedPublic

Authored by vlorentz on Fri, Jan 10, 3:08 PM.

Details

Summary

Also deduplicates code used to call sentry_sdk.init by making all our
init code go through the same function swh.core.sentry.init_sentry."

Diff Detail

Repository
rDCORE Foundations and core functionalities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Fri, Jan 10, 3:08 PM
douardda requested changes to this revision.Mon, Jan 13, 10:32 AM
douardda added a subscriber: douardda.

I'm a bit puzzled by the 2 revisions in this diff. Are they related? I don't really see how/why.

Also please consider better commit message with the 'why' (why do we need "Allow subclasses of RPCClient to override generated methods", and even if i might appear king of obvious, why do we need this SWH_MAIN_PACKAGE).

BTW there seem to be a typo in this commit message (there is a closing " without an opening one).

This revision now requires changes to proceed.Mon, Jan 13, 10:32 AM

Oh maybe it's a mixed up 'arc diff --update' (with D2515)

vlorentz updated this revision to Diff 8947.Mon, Jan 13, 2:05 PM

remove unwanted commit

vlorentz retitled this revision from Allow subclasses of RPCClient to override generated methods. to Add env var SWH_MAIN_PACKAGE to initialize sentry_sdk with a release..Mon, Jan 13, 2:05 PM
vlorentz edited the summary of this revision. (Show Details)

code from D2442 got mixed up with this diff. fixed

olasd accepted this revision.Tue, Jan 14, 2:40 PM
ardumont accepted this revision.Wed, Jan 15, 11:09 AM
douardda accepted this revision.Wed, Jan 15, 11:13 AM

I'm fine with the code, but as I already said, I'd really like the commit message to have a paragraph on why this is needed and what problem it solves.

It might be obvious for the author of the diff but not for someone with no particular knowledge in sentry reading the git log...

This revision is now accepted and ready to land.Wed, Jan 15, 11:13 AM
vlorentz updated this revision to Diff 9004.Wed, Jan 15, 1:06 PM

update commit message

This revision was landed with ongoing or failed builds.Wed, Jan 15, 1:06 PM
This revision was automatically updated to reflect the committed changes.