Page MenuHomeSoftware Heritage

Add env var SWH_MAIN_PACKAGE to initialize sentry_sdk with a release.
ClosedPublic

Authored by vlorentz on Jan 10 2020, 3:08 PM.

Details

Summary

Also deduplicates code used to call sentry_sdk.init by making all our
init code go through the same function swh.core.sentry.init_sentry."

Diff Detail

Repository
rDCORE Foundations and core functionalities
Branch
sentry-main-package
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10050
Build 14877: tox-on-jenkinsJenkins
Build 14876: arc lint + arc unit

Event Timeline

douardda added a subscriber: douardda.

I'm a bit puzzled by the 2 revisions in this diff. Are they related? I don't really see how/why.

Also please consider better commit message with the 'why' (why do we need "Allow subclasses of RPCClient to override generated methods", and even if i might appear king of obvious, why do we need this SWH_MAIN_PACKAGE).

BTW there seem to be a typo in this commit message (there is a closing " without an opening one).

This revision now requires changes to proceed.Jan 13 2020, 10:32 AM

Oh maybe it's a mixed up 'arc diff --update' (with D2515)

vlorentz retitled this revision from Allow subclasses of RPCClient to override generated methods. to Add env var SWH_MAIN_PACKAGE to initialize sentry_sdk with a release..Jan 13 2020, 2:05 PM
vlorentz edited the summary of this revision. (Show Details)

code from D2442 got mixed up with this diff. fixed

I'm fine with the code, but as I already said, I'd really like the commit message to have a paragraph on why this is needed and what problem it solves.

It might be obvious for the author of the diff but not for someone with no particular knowledge in sentry reading the git log...

This revision is now accepted and ready to land.Jan 15 2020, 11:13 AM
This revision was landed with ongoing or failed builds.Jan 15 2020, 1:06 PM
This revision was automatically updated to reflect the committed changes.