isn't blake2s256 missing here?

and, more generally, rather than hardcoding the list of hashing algorithms everywhere in the web UI, can't we use swh.model.hashutil.ALGORITHMS (and/or DEFAULT_ALGORITHMS) where appropriate?

shouldn't we also test blake2 here?

if it's missing from our testdata, we should probably update those

To clarify the use of those variables.

• swh.model.hashutil.ALGORITHMS references the supported algorithms for hashing.

• swh.model.hashutil.DEFAULT_ALGORITHMS references the algorithms used by default by the hashing functions when nothing is specified. The loaders for example, mostly do not specify those, thus using DEFAULT_ALGORITHMS. Thus, that should be the the one to use here.

... Thus, that should be the the one to use here.

I assumed wrongly that the hashes won't change in time.
So the full list should be used (ALGORITHMS) instead.

Ok, currently testing using the swh.model.hashutil.ALGORITHMS set.

Nevertheless, there is a side effect of now using it. As hashutil.ALGORITHMS is a set,
the order of iteration on its elements can vary between Python sessions (while the order
of iteration is guaranteed to be the same on the current one).

So enriched content data with /filetype/language/license url will now use the first checksum
returned when iterating on ALGORITHMS. We should have a hint in swh.model.hashutil
on which default hash to use.

I keep current implementation of enrich_content until we find a proper solution.

If you want a reproducible order, you can just use sorted(ALGORITHMS) ?

In my opinion, this "enrichment" function should really reuse the query string that we used for getting to the content in the first place, rather than picking an arbitrary default.

dictionnary -> dict(ionary)

I agree about reusing the same query string (with default one 'sha1' as before), it would be more coherent.

for napoleon/rst, the above should be formatted as:

Args:
    content: dict of data associated to a swh content object
    top_url: whether or not to include the content url in
        the enriched data
    query_string: optionnal query string of type '<algo>:<hash>'
        used when requesting the content, it acts as a hint
        for picking the same hash method when computing
        the url listed above

i.e., the indentation level for continuation lines is constant, does not depend on the length of the identifier

unrelated: "optionnal" -> "optional"

language ;p