Page MenuHomeSoftware Heritage
Differential D2443

Deduplicate client code.
ClosedPublic
Actions

Authored by vlorentz on Dec 12 2019, 6:17 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDSTOC869100bc08cf: Deduplicate client code.

Diff Detail

Repository
rDSTO Storage manager
Branch
deduplicate-client
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9734
Build 14350: tox-on-jenkinsJenkins
Build 14349: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 12 2019, 6:17 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 12 2019, 6:17 PM
Harbormaster failed remote builds in B9731: Diff 8644!Dec 12 2019, 6:17 PM
swh-public-ci added a comment.Dec 12 2019, 6:17 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/820/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/820/console

vlorentz updated this revision to Diff 8645.Dec 12 2019, 6:18 PM

fix typos

Harbormaster failed remote builds in B9732: Diff 8645!Dec 12 2019, 6:19 PM
swh-public-ci added a comment.Dec 12 2019, 6:19 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/821/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/821/console

vlorentz edited the summary of this revision. (Show Details)Dec 12 2019, 6:22 PM
vlorentz removed a parent revision: D2442: Allow subclasses of RPCClient to override generated methods..
vlorentz updated this revision to Diff 8646.Dec 12 2019, 6:22 PM

rewrite without requiring the other diff (+ no remote_api_endpoint() for non-POST endpoints)

Harbormaster failed remote builds in B9733: Diff 8646!Dec 12 2019, 6:23 PM
swh-public-ci added a comment.Dec 12 2019, 6:23 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/822/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/822/console

vlorentz updated this revision to Diff 8647.Dec 12 2019, 6:26 PM

rebase

swh-public-ci added a comment.Dec 12 2019, 6:28 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/823/ for more details.

Harbormaster completed remote builds in B9734: Diff 8647.Dec 12 2019, 6:28 PM
vlorentz added a child revision: D2444: Deduplicate server code..Dec 12 2019, 7:02 PM
anlambert accepted this revision.Dec 13 2019, 4:52 PM
anlambert added a subscriber: anlambert.

Looks good to me !

swh/storage/api/client.py
208–212

Why omitting these ones ?

This revision is now accepted and ready to land.Dec 13 2019, 4:52 PM
vlorentz added inline comments.Dec 13 2019, 4:57 PM
swh/storage/api/client.py
208–212

they are get instead of post

anlambert added inline comments.Dec 16 2019, 10:58 AM
swh/storage/api/client.py
208–212

Oh I see. Maybe the support of the type of requests could be added in the remote_api_endpoint decorator in the future ?

vlorentz closed this revision.Dec 16 2019, 2:13 PM

Landed as 869100bc08cf99e5ba2cbf451a1792ba8eb34f43.

vlorentz added a commit: rDSTOC869100bc08cf: Deduplicate client code..Jan 16 2020, 5:22 PM

Revision Contents
Changeset List

PathSize
swh/
storage/
api/
245 lines
82 lines

Diff 8647

View Options

swh/storage/api/client.py

Loading...
View Options

swh/storage/storage.py

Loading...
About · Developer information · Legal