Page MenuHomeSoftware Heritage

Deduplicate client code.
ClosedPublic

Authored by vlorentz on Dec 12 2019, 6:17 PM.

Details

Diff Detail

Repository
rDSTO Storage manager
Branch
deduplicate-client
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9732
Build 14346: tox-on-jenkinsJenkins
Build 14345: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 12 2019, 6:17 PM
vlorentz updated this revision to Diff 8645.Dec 12 2019, 6:18 PM

fix typos

vlorentz updated this revision to Diff 8646.Dec 12 2019, 6:22 PM

rewrite without requiring the other diff (+ no remote_api_endpoint() for non-POST endpoints)

anlambert accepted this revision.Dec 13 2019, 4:52 PM
anlambert added a subscriber: anlambert.

Looks good to me !

swh/storage/api/client.py
200–204

Why omitting these ones ?

This revision is now accepted and ready to land.Dec 13 2019, 4:52 PM
vlorentz added inline comments.Dec 13 2019, 4:57 PM
swh/storage/api/client.py
200–204

they are get instead of post

anlambert added inline comments.Dec 16 2019, 10:58 AM
swh/storage/api/client.py
200–204

Oh I see. Maybe the support of the type of requests could be added in the remote_api_endpoint decorator in the future ?

vlorentz closed this revision.Dec 16 2019, 2:13 PM

Landed as 869100bc08cf99e5ba2cbf451a1792ba8eb34f43.