Page MenuHomeSoftware Heritage
Differential D2445

Move origin_visit_get_random to the right place in the code and fix its docstring.
ClosedPublic
Actions

Authored by vlorentz on Dec 12 2019, 7:09 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTOCfe6ac8f9942a: Move origin_visit_get_random to the right place in the code and fix its…
rDSTOfe6ac8f9942a: Move origin_visit_get_random to the right place in the code and fix its…
Summary

Depends on D2444.

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 12 2019, 7:09 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 12 2019, 7:09 PM
vlorentz updated this revision to Diff 8650.Dec 12 2019, 7:10 PM

also fix in-mem storage

vlorentz updated this revision to Diff 8651.Dec 12 2019, 7:11 PM

fix typo

swh-public-ci added a comment.Dec 12 2019, 7:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/825/ for more details.

Harbormaster completed remote builds in B9736: Diff 8649.Dec 12 2019, 7:11 PM
vlorentz updated this revision to Diff 8652.Dec 12 2019, 7:12 PM

fix docstring better

swh-public-ci added a comment.Dec 12 2019, 7:14 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/826/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/826/console

Harbormaster failed remote builds in B9737: Diff 8650!Dec 12 2019, 7:14 PM
swh-public-ci added a comment.Dec 12 2019, 7:16 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/827/ for more details.

Harbormaster completed remote builds in B9738: Diff 8651.Dec 12 2019, 7:16 PM
swh-public-ci added a comment.Dec 12 2019, 7:18 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/828/ for more details.

Harbormaster completed remote builds in B9739: Diff 8652.Dec 12 2019, 7:18 PM
vlorentz added a child revision: D2452: Add {content,directory,revision,release,snapshot}_get_random..Dec 13 2019, 2:06 PM
ardumont added a subscriber: ardumont.Dec 16 2019, 9:39 AM

What's the right place?

swh/storage/storage.py
1502

might as well add its str type now (which is missing).

1505–1506

extra blank

1509

func:origin_visit_get?

ardumont added inline comments.Dec 16 2019, 9:41 AM
swh/storage/storage.py
1509

(or whatever sphinx's docstring stanza to link to another method/function is)

ardumont accepted this revision.Dec 16 2019, 9:42 AM

lgtm

please check and fix the remarks though, they are small enough ;)

This revision is now accepted and ready to land.Dec 16 2019, 9:42 AM
vlorentz added a comment.Dec 16 2019, 1:30 PM
In D2445#58032, @ardumont wrote:

What's the right place?

With other origin_visit methods, instead of being in the middle of origin methods.

ardumont added a comment.Dec 16 2019, 1:33 PM

What's the right place?

With other origin_visit methods, instead of being in the middle of origin methods.

ok

ah yes, i remember, it started as an origin retrieval (got even named origin_get_random initially).
It became a visit retrieval in the end and i forgot to move it ;)

vlorentz updated this revision to Diff 8680.Dec 16 2019, 1:37 PM

rebase + apply @ardumont's comments

vlorentz added a comment.Dec 16 2019, 1:37 PM
In D2445#58050, @ardumont wrote:

What's the right place?

With other origin_visit methods, instead of being in the middle of origin methods.

ok

ah yes, i remember, it started as an origin retrieval (got even named origin_get_random initially).
It became a visit retrieval in the end and i forgot to move it ;)

I figured as much from the position and the docstrings before this diff

vlorentz updated this revision to Diff 8682.Dec 16 2019, 1:38 PM

fix base

swh-public-ci added a comment.Dec 16 2019, 1:39 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/831/ for more details.

Harbormaster completed remote builds in B9768: Diff 8680.Dec 16 2019, 1:39 PM
Harbormaster failed remote builds in B9770: Diff 8682!Dec 16 2019, 1:42 PM
swh-public-ci added a comment.Dec 16 2019, 1:42 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/833/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/833/console

swh-public-ci added a comment.Dec 16 2019, 2:03 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/835/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/835/console

This revision was landed with ongoing or failed builds.Dec 16 2019, 2:09 PM
Closed by commit rDSTOfe6ac8f9942a: Move origin_visit_get_random to the right place in the code and fix its… (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSTOfe6ac8f9942a: Move origin_visit_get_random to the right place in the code and fix its….
vlorentz added a commit: rDSTOCfe6ac8f9942a: Move origin_visit_get_random to the right place in the code and fix its….Jan 16 2020, 5:22 PM

Revision Contents
Changeset List

PathSize
swh/
storage/
48 lines
61 lines
36 lines

Diff 8686

View Options

swh/storage/db.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/storage.py

Loading...
About · Developer information · Legal