Page MenuHomeSoftware Heritage

swh.web.setting: Use different setup according to platform (dev/prod)
ClosedPublic

Authored by ardumont on Sep 11 2017, 7:42 PM.

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 997
Build 1320: Software Heritage Python tests
Build 1319: arc lint + arc unit

Event Timeline

resources/test/webapp.yml
28

I'm not sure we want to keep that file (it's no longer used).

pros:

  • it's with the code (might as well be in a readme though).

cons:

  • redundant with swh-site/defaults.yaml (if you know where to look).
swh/web/config.py
21–28

typo: cache_uri...

  • swh.web.setting: Permit to setup the cache uri from webapp.yml
  • cleanup: Remove db.sqlite3 binary from git

Fixed CI (due to swh-web's new dependencies not installed on CI worker)

Rebase to latest master + fix some default config property level

  • swh.web.setting: Use different setup according to platform (dev/prod)
  • swh.web.setting: Permit to setup the cache uri from webapp.yml
  • cleanup: Remove db.sqlite3 binary from git
  • swh.web.config: Fix cache_uri and limits to the right level
  • swh.web.config: Set config default as near as production

Rebased + clarify setup according to latest discussion with anlambert

  • swh.web.setting: Use different setup according to platform (dev/prod)
  • swh.web.setting: Permit to setup the cache uri from webapp.yml
  • swh.web.config: Fix cache_uri and limits to the right level
  • swh.web.config: Set config default as near as production
  • swh.web.throttling: Clarify config keys intent
swh/web/config.py
24

The setup keys was at the wrong level. I fixed that.

The terms were either redundant or not clear.
After discussion with anlambert, we settled on:

  • 'throttling' as main keys
  • 'scopes': for the listing of scopes setup
  • swh.web.setting: Use different setup according to platform (dev/prod)
  • swh.web.setting: Permit to setup the cache uri from webapp.yml
  • swh.web.config: Fix cache_uri and limits to the right level
  • swh.web.config: Set config default as near as production
  • swh.web.throttling: Clarify config keys intent
  • swh.web.settings.common: Remove throttling inhibition in DEBUG mode
  • resources: Remove unused setup file

Rewording commits appropriately

  • swh.web.settings: Split setup according to platforms (dev/prod)
  • swh.web.settings: Setup cache uri (if any) from webapp.yml
  • swh.web.config: Fix cache_uri and limits to the right level
  • swh.web.config: Set config default as near as production
  • swh.web.throttling: Clarify config keys intent
  • swh.web.settings.common: Remove throttling inhibition in DEBUG mode
  • resources: Remove unused setup file
This revision is now accepted and ready to land.Sep 12 2017, 11:58 AM
This revision was automatically updated to reflect the committed changes.