Page MenuHomeSoftware Heritage

Attempt to rationalize a bit workers config in docker
ClosedPublic

Authored by douardda on Dec 12 2019, 12:17 PM.

Details

Summary
  • use a common workers.env file for all worker services,
  • move services/swh-loaders-worker/entrypoint.sh in services/swh-worker/ and use where possible in docker-compose.yml,
  • merge docker/env/statsd.env in common_python.env.

It could be possible to rationalize more, eg. merging all worker entrypoint.sh
in a single one.

Diff Detail

Repository
rDENV Development environment
Branch
current
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 9694
Build 14289: arc lint + arc unit

Event Timeline

douardda created this revision.Dec 12 2019, 12:17 PM
vlorentz accepted this revision.Dec 12 2019, 1:35 PM
vlorentz added a subscriber: vlorentz.

Why did you make services/swh-worker/entrypoint.sh non-executable?

Nitpick: env/workers.env should be named env/gunicorn_workers.env (or env/gunicorn_worker.env)

This revision is now accepted and ready to land.Dec 12 2019, 1:35 PM
ardumont added inline comments.
docker/docker-compose.yml
341

(un)related, we should decide whether to use singular or plural
i'd say singular since the 2 other choices below (loader, indexer) are.

This revision was automatically updated to reflect the committed changes.