Page MenuHomeSoftware Heritage
Differential D2424

Enable Sentry for CLIs, and Gunicorn and Celery workers.
ClosedPublic
Actions

Authored by vlorentz on Dec 10 2019, 2:53 PM.

Details

Reviewers
ardumont
olasd
Group Reviewers
Reviewers
Commits
rDENV936fa4e08df5: Enable Sentry for CLIs and Gunicorn workers.

Diff Detail

Repository
rDENV Development environment
Branch
sentry
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9673
Build 14255: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 10 2019, 2:53 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 10 2019, 2:53 PM
Harbormaster completed remote builds in B9658: Diff 8578.Dec 10 2019, 2:53 PM
vlorentz updated this revision to Diff 8579.Dec 10 2019, 2:56 PM

add comment

Harbormaster completed remote builds in B9659: Diff 8579.Dec 10 2019, 2:56 PM
ardumont added a subscriber: ardumont.Dec 10 2019, 2:57 PM
ardumont added inline comments.
docker/env/common_python.env
5

why is it empty?

ardumont added inline comments.Dec 10 2019, 2:58 PM
docker/env/common_python.env
5

Because no sentry in the docker env?

vlorentz added inline comments.Dec 10 2019, 2:58 PM
docker/env/common_python.env
5

We decided against running Sentry in our Docker env, it's too big and too niche. Instead, you should run it on your own.

ardumont added inline comments.Dec 10 2019, 3:05 PM
docker/env/common_python.env
5

ack.

But why do we need to specify this if this is empty?

ardumont accepted this revision.Dec 10 2019, 3:06 PM
This revision is now accepted and ready to land.Dec 10 2019, 3:06 PM
vlorentz added inline comments.Dec 10 2019, 3:28 PM
docker/env/common_python.env
5

We don't need to.

vlorentz updated this revision to Diff 8580.Dec 10 2019, 3:29 PM

comment out SWH_SENTRY_DSN.

Harbormaster completed remote builds in B9661: Diff 8580.Dec 10 2019, 3:29 PM
vlorentz marked 3 inline comments as done.Dec 10 2019, 3:29 PM
vlorentz retitled this revision from [WIP] Enable Sentry for CLIs and Gunicorn workers. to Enable Sentry for CLIs and Gunicorn workers..
vlorentz updated this revision to Diff 8588.Dec 11 2019, 2:00 PM

add documentation.

Harbormaster completed remote builds in B9671: Diff 8588.Dec 11 2019, 2:00 PM
vlorentz updated this revision to Diff 8589.Dec 11 2019, 2:02 PM

rebase.

Harbormaster completed remote builds in B9672: Diff 8589.Dec 11 2019, 2:02 PM
douardda added a subscriber: douardda.Dec 11 2019, 2:06 PM
douardda added inline comments.
docker/docker-compose.yml
269

? swh-deposit-api is now swh-scheduler

olasd accepted this revision.Dec 11 2019, 2:10 PM
vlorentz updated this revision to Diff 8590.Dec 11 2019, 2:11 PM

fix rebase

Harbormaster completed remote builds in B9673: Diff 8590.Dec 11 2019, 2:11 PM
vlorentz added inline comments.Dec 11 2019, 2:11 PM
docker/docker-compose.yml
269

oops, I messed up my rebase

vlorentz retitled this revision from Enable Sentry for CLIs and Gunicorn workers. to Enable Sentry for CLIs, and Gunicorn and Celery workers..Dec 11 2019, 2:12 PM
Closed by commit rDENV936fa4e08df5: Enable Sentry for CLIs and Gunicorn workers. (authored by vlorentz). · Explain WhyDec 11 2019, 2:12 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDENV936fa4e08df5: Enable Sentry for CLIs and Gunicorn workers..
vlorentz mentioned this in T2142: Document how to use Sentry with the docker dev environment.Dec 11 2019, 3:39 PM

Revision Contents
Changeset List

PathSize
docker/
11 lines
19 lines
env/
5 lines
services/
swh-deposit/
1 line
swh-indexer-storage/
1 line
swh-objstorage/
1 line
swh-scheduler/
1 line
swh-search/
1 line
swh-storage-replayer/
2 lines
swh-storage/
1 line
swh-web/
1 line

Diff 8590

View Options

docker/README.md

Loading...
View Options

docker/docker-compose.yml

Loading...
View Options

docker/env/common_python.env

Loading...
View Options

docker/services/swh-deposit/entrypoint.sh

Loading...
View Options

docker/services/swh-indexer-storage/entrypoint.sh

Loading...
View Options

docker/services/swh-objstorage/entrypoint.sh

Loading...
View Options

docker/services/swh-scheduler/entrypoint.sh

Loading...
View Options

docker/services/swh-search/entrypoint.sh

Loading...
View Options

docker/services/swh-storage-replayer/entrypoint.sh

Loading...
View Options

docker/services/swh-storage/entrypoint.sh

Loading...
View Options

docker/services/swh-web/entrypoint.sh

Loading...
About · Developer information · Legal