Page MenuHomeSoftware Heritage
Differential D2419

origin_save: Add some statsd monitoring metrics
AbandonedPublic
Actions

Authored by anlambert on Dec 9 2019, 4:55 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Summary

Add a counter for the number of submitted save requests and a gauge
to keep track of the number of pending requests to review.

Related to T2124

Diff Detail

Repository
rDWAPPS Web applications
Branch
add-save-requests-stats
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9628
Build 14178: Cypress tests for swh-web diffsJenkins
Build 14177: tox-on-jenkinsJenkins
Build 14176: arc lint + arc unit

Event Timeline

anlambert created this revision.Dec 9 2019, 4:55 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 9 2019, 4:55 PM
swh-public-ci added a comment.Dec 9 2019, 4:57 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/832/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/832/console

Harbormaster failed remote builds in B9627: Diff 8546!Dec 9 2019, 4:57 PM
anlambert removed a parent revision: D2407: Fix tests data initialization after git loader api changes.Dec 9 2019, 4:58 PM
anlambert updated this revision to Diff 8547.Dec 9 2019, 4:59 PM
anlambert added a parent revision: D2407: Fix tests data initialization after git loader api changes.

Rebase to master in order for the tests to pass

swh-public-ci added a comment.Dec 9 2019, 4:59 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/430/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/430/console

anlambert updated this revision to Diff 8548.Dec 9 2019, 5:00 PM

Remove commit from D2407

anlambert edited the summary of this revision. (Show Details)Dec 9 2019, 5:00 PM
anlambert removed a parent revision: D2407: Fix tests data initialization after git loader api changes.
swh-public-ci added a comment.Dec 9 2019, 5:01 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/833/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/833/console

Harbormaster failed remote builds in B9628: Diff 8547!Dec 9 2019, 5:02 PM
swh-public-ci added a comment.Dec 9 2019, 5:04 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/431/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/431/console

swh-public-ci added a comment.Dec 9 2019, 5:05 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/834/ for more details.

swh-public-ci added a comment.Dec 9 2019, 5:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/432/ for more details.

Harbormaster completed remote builds in B9629: Diff 8548.Dec 9 2019, 5:14 PM
anlambert mentioned this in T2124: Save Code Now: monitoring of admin infra.Dec 10 2019, 11:26 AM
anlambert updated this revision to Diff 8557.Dec 10 2019, 11:49 AM

Rebase

swh-public-ci added a comment.Dec 10 2019, 11:53 AM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/837/ for more details.

swh-public-ci added a comment.Dec 10 2019, 12:02 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/435/ for more details.

Harbormaster completed remote builds in B9637: Diff 8557.Dec 10 2019, 12:02 PM
vlorentz requested changes to this revision.Dec 10 2019, 3:40 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/web/common/origin_save.py
356–358

it should be an an else statement, we don't want a counter for pending tasks.

This revision now requires changes to proceed.Dec 10 2019, 3:40 PM
anlambert mentioned this in D2432: Add prometheus metrics for origin save requests.Dec 11 2019, 6:05 PM
anlambert abandoned this revision.Dec 11 2019, 6:06 PM

Abandon this in favor of D2432

Revision Contents
Changeset List

PathSize
swh/
web/
admin/
5 lines
common/
21 lines
tests/
admin/
33 lines
api/
views/
17 lines
19 lines

Diff 8547

View Options

swh/web/admin/origin_save.py

Loading...
View Options

swh/web/common/origin_save.py

Loading...
View Options

swh/web/tests/admin/test_origin_save.py

Loading...
View Options

swh/web/tests/api/views/test_origin_save.py

Loading...
View Options

swh/web/tests/data.py

Loading...
About · Developer information · Legal