Page MenuHomeSoftware Heritage
Differential D2373

Fix release_identifier for snapshot target
ClosedPublic
Actions

Authored by anlambert on Nov 28 2019, 4:54 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDMODda6475615221: identifiers: Fix release_identifier for snapshot target
Summary

While playing with swh-model, I noticed the release_identifier function ends
up with error when a release target type is a snapshot (what does it mean by the way,
I can't picture it).

A mapping between 'snapshot' to its git equivalent was missing. Looking at the git glossary,
refs seems the best choice here but maybe I am wrong.

Diff Detail

Repository
rDMOD Data model
Branch
fix-release-identifier-snapshot-target
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9430
Build 13841: tox-on-jenkinsJenkins
Build 13840: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 28 2019, 4:54 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 28 2019, 4:54 PM
swh-public-ci added a comment.Nov 28 2019, 4:55 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/151/ for more details.

Harbormaster completed remote builds in B9430: Diff 8358.Nov 28 2019, 4:55 PM
anlambert added a child revision: D2375: Add automatic object identifier computation support.Nov 28 2019, 5:21 PM
vlorentz accepted this revision.Nov 29 2019, 1:58 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/model/tests/test_identifiers.py
670

you forgot to remove this line

This revision is now accepted and ready to land.Nov 29 2019, 1:58 PM
anlambert updated this revision to Diff 8373.Nov 29 2019, 2:02 PM

Update: Forgot to remove print statement

swh-public-ci added a comment.Nov 29 2019, 2:03 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/153/ for more details.

Harbormaster completed remote builds in B9445: Diff 8373.Nov 29 2019, 2:03 PM
Closed by commit rDMODda6475615221: identifiers: Fix release_identifier for snapshot target (authored by anlambert). · Explain WhyNov 29 2019, 2:05 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDMODda6475615221: identifiers: Fix release_identifier for snapshot target.
olasd added a subscriber: olasd.Nov 29 2019, 2:20 PM

Thanks!

I'm just a tiny bit worried that this "swh extension" might clash with something that upstream git implements, if we reuse git terminology.

I'd be more comfortable with using something obviously ours, like "swh-snp". That way the chance of "upstream" clash goes down to zero.

anlambert removed a child revision: D2375: Add automatic object identifier computation support.Nov 29 2019, 2:46 PM

Revision Contents
Changeset List

PathSize
swh/
model/
1 line
tests/
12 lines

Diff 8358

View Options

swh/model/identifiers.py

Loading...
View Options

swh/model/tests/test_identifiers.py

Loading...
About · Developer information · Legal