Details

Reviewers

vlorentz
ardumont

Group Reviewers

Reviewers

Commits

rDSTOCbc0e81c3d140: pre-commit: explicitely whitelist 'iff' when running codespell
rDSTOC29eb5489580f: Fix a few typos reported by codespell
rDSTOC264cd33b77aa: Add a pre-commit-hooks.yaml config file
rDSTOC1472c8e89334: fix trailing ws reported by pre-commit
rDSTO29eb5489580f: Fix a few typos reported by codespell
rDSTObc0e81c3d140: pre-commit: explicitely whitelist 'iff' when running codespell
rDSTO1472c8e89334: fix trailing ws reported by pre-commit
rDSTO264cd33b77aa: Add a pre-commit-hooks.yaml config file

Summary

also

fix trailing ws reported by pre-commit
pre-commit: explicitely whitelist 'iff' when running codespell
Fix a few typos reported by codespell

Test Plan

try it using pre-commit run --all-files

See following diff for some fixes in utils and bin scripts.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 9197
Build 13457: tox-on-jenkins	Jenkins
Build 13456: arc lint + arc unit

Event Timeline

douardda created this revision.Nov 20 2019, 11:50 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 20 2019, 11:50 AM

douardda added a child revision: D2313: Remove utils/(dump|fix)_revisions scripts.Nov 20 2019, 11:51 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/789/ for more details.

Harbormaster completed remote builds in B9144: Diff 7954.Nov 20 2019, 11:53 AM

run mypy on the whole swh/ directory

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/792/ for more details.

Harbormaster completed remote builds in B9148: Diff 7958.Nov 20 2019, 12:30 PM

Include fixes reported by pre-commit hooks in this diff

fix trailing ws reported by pre-commit
pre-commit: explicitely whitelist 'iff' when running codespell
Fix a few typos reported by codespell

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/793/ for more details.

Harbormaster completed remote builds in B9149: Diff 7959.Nov 20 2019, 12:34 PM

For the mypy check, instead of listing the needed dependencies in one more file, and instead of depending on an external hook repository, we could run it as a system hook (which will run in your own dev venv) instead of a python hook (which runs in an isolated venv).

In D2312#54360, @olasd wrote:

For the mypy check, instead of listing the needed dependencies in one more file, and instead of depending on an external hook repository, we could run it as a system hook (which will run in your own dev venv) instead of a python hook (which runs in an isolated venv).

Ah, I understand why the comment I submitted yesterday got lost: it's in another diff! :)

rewrite the mypy hook as a language:system one

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/796/ for more details.

Harbormaster completed remote builds in B9188: Diff 7976.Nov 21 2019, 11:17 AM

douardda removed a child revision: D2313: Remove utils/(dump|fix)_revisions scripts.Nov 21 2019, 11:21 AM

fix mypy.ini and rebase

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/801/ for more details.

Harbormaster completed remote builds in B9197: Diff 7985.Nov 21 2019, 11:27 AM

remove useless mypy.ini entry

since we do not run mypy on setup.py

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/802/ for more details.

Harbormaster completed remote builds in B9209: Diff 7993.Nov 21 2019, 1:21 PM

cool, runs fine on my side:

$ workon swh
$ cd swh-storage
$ arc patch D2312
$ pre-commit run --all-files
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/codespell-project/codespell.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/codespell-project/codespell.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Trim Trailing Whitespace.................................................Passed
Flake8...................................................................Passed
Check JSON...............................................................Passed
Check Yaml...............................................................Passed
codespell................................................................Passed
mypy.....................................................................Passed