Otherwise, this feels weird to have database declarations only related to the debian lister/loader in swh-storage.
Maybe this could be moved in swh-lister or swh-loader-debian ?

swh/storage/tests/schemata/conftest.py
11	Using `@pytest.fixture` is sufficient here (see pytest doc)
swh/storage/tests/schemata/test_distribution.py
12	same here

This revision now requires changes to proceed.Nov 13 2019, 11:12 AM

In D2264#53241, @anlambert wrote:

Otherwise, this feels weird to have database declarations only related to the debian lister/loader in swh-storage.
Maybe this could be moved in swh-lister or swh-loader-debian ?

Both the lister and loader use these models; It made sense, at the time it was introduced, to put this functionality in a swh.storage subpackage, rather than introduce a dependency between lister and loader.

Use @pytest.fixture instead of yield_fixture

anlambert accepted this revision.Nov 13 2019, 1:10 PM

This revision is now accepted and ready to land.Nov 13 2019, 1:10 PM

olasd mentioned this in D2267: Move to @pytest.fixture from yield_fixture.Nov 13 2019, 1:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/777/ for more details.

Harbormaster completed remote builds in B8990: Diff 7809.Nov 13 2019, 1:13 PM

Closed by commit rDSTObb5d4051a491: Add minimal test coverage for swh.storage.schemata (authored by olasd). · Explain WhyNov 13 2019, 1:13 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTObb5d4051a491: Add minimal test coverage for swh.storage.schemata.

olasd mentioned this in rDCOREcdf601196b2d: Move to @pytest.fixture from yield_fixture.

Otherwise, this feels weird to have database declarations only related to the debian lister/loader in swh-storage.
Maybe this could be moved in swh-lister or swh-loader-debian ?

For info, it's already been moved to swh-lister (see swh.lister.debian.models which is almost the same as schemata, almost because it got slightly adapted since).
As i am currently deploying the latest lister-debian and the new debian-loader... I waited for this to be deployed and running in production prior to remove it from swh.storage (the old debian-loader still depends on this even if it's not really running).
I'll do migrate those tests as well in due time.

Cheers,

Otherwise, this feels weird to have database declarations only related to the debian lister/loader in swh-storage.
Maybe this could be moved in swh-lister or swh-loader-debian ?

For info, it's already been moved to swh-lister (see swh.lister.debian.models which is almost the same as schemata, almost because it got slightly adapted since).
As i am currently deploying the latest lister-debian and the new debian-loader... I waited for this to be deployed and running in production prior to remove it from swh.storage (the old debian-loader still depends on this even if it's not really running).
I'll do migrate those tests as well in due time.

done in D2273 btw

olasd added a commit: rDSTOCbb5d4051a491: Add minimal test coverage for swh.storage.schemata.Jan 16 2020, 5:22 PM