Differential D2263

Fix bogus NotImplementedError on Area.index_uris
ClosedPublic
Actions

Authored by olasd on Nov 12 2019, 7:10 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Commits

rDSTOCd788677c0ff4: Fix bogus NotImplementedError on Area.index_uris
rDSTOd788677c0ff4: Fix bogus NotImplementedError on Area.index_uris

Summary

This would raise when the iteration terminates even though the uris were
generated.

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Nov 12 2019, 7:10 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 12 2019, 7:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/774/ for more details.

Harbormaster completed remote builds in B8970: Diff 7793.Nov 12 2019, 7:12 PM

olasd added a child revision: D2264: Add minimal test coverage for swh.storage.schemata.Nov 12 2019, 7:56 PM

anlambert accepted this revision.Nov 13 2019, 10:50 AM

This revision is now accepted and ready to land.Nov 13 2019, 10:50 AM

Closed by commit rDSTOd788677c0ff4: Fix bogus NotImplementedError on Area.index_uris (authored by olasd). · Explain WhyNov 13 2019, 11:00 AM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTOd788677c0ff4: Fix bogus NotImplementedError on Area.index_uris.

olasd added a commit: rDSTOCd788677c0ff4: Fix bogus NotImplementedError on Area.index_uris.Jan 16 2020, 5:22 PM

Revision Contents
Changeset List

Path

Size

swh/

storage/

schemata/

distribution.py

9 lines

Diff 7802

swh/storage/schemata/distribution.py

Loading...