Page MenuHomeSoftware Heritage

Use type attribute from visit instead of origin
ClosedPublic

Authored by anlambert on Oct 22 2019, 3:42 PM.

Details

Summary

As origin type attribute will be removed in favor of visit type attribute, remove any reference of it in swh-web codebase and use visit type instead.

As a consequence, the web api endpoint /api/1/origin/(origin_type)/url/(origin_url)/ has been removed.
I can add it back for backward compatibility if needed but considering it has been marked as deprecated since a couple of months, I do not think it is necessary.

Related T1891

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Oct 22 2019, 3:42 PM
anlambert updated this revision to Diff 7400.Oct 22 2019, 4:04 PM

Update: Fix failing test

olasd accepted this revision.Oct 23 2019, 1:06 PM
olasd added a subscriber: olasd.

This all looks good, thanks.

This revision is now accepted and ready to land.Oct 23 2019, 1:06 PM