Paths

Table of Contentst

Differential D2167

Use type attribute from visit instead of origin
ClosedPublic
Actions

Authored by anlambert on Oct 22 2019, 3:42 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDWAPPS0a765b7dc026: swh-web: Use type attribute from visit instead of origin

Summary

As origin type attribute will be removed in favor of visit type attribute, remove any reference of it in swh-web codebase and use visit type instead.

As a consequence, the web api endpoint [[ https://archive.softwareheritage.org/api/1/origin/ | /api/1/origin/(origin_type)/url/(origin_url)/ ]] has been removed.
I can add it back for backward compatibility if needed but considering it has been marked as deprecated since a couple of months, I do not think it is necessary.

Related T1891

Diff Detail

Repository

rDWAPPS Web applications

Branch

remove-origin-type

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 8599
Build 12492: Cypress tests for swh-web diffs	Jenkins
Build 12491: tox-on-jenkins	Jenkins
Build 12490: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 22 2019, 3:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 22 2019, 3:42 PM

anlambert added a child revision: D2168: Better handle aliases in snapshot content.Oct 22 2019, 3:47 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/741/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/741/console

Harbormaster failed remote builds in B8599: Diff 7398!Oct 22 2019, 3:48 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/343/ for more details.

Update: Fix failing test

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/743/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/345/ for more details.

Harbormaster completed remote builds in B8601: Diff 7400.Oct 22 2019, 4:13 PM

This all looks good, thanks.

This revision is now accepted and ready to land.Oct 23 2019, 1:06 PM

Closed by commit rDWAPPS0a765b7dc026: swh-web: Use type attribute from visit instead of origin (authored by anlambert). · Explain WhyOct 23 2019, 1:13 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS0a765b7dc026: swh-web: Use type attribute from visit instead of origin.

vlorentz mentioned this in T2158: Properly deal with removed endpoints.Dec 17 2019, 5:02 PM

Revision Contents
Changeset List

Path

Size

cypress/

integration/

origin-save.spec.js

4 lines

docs/

uri-scheme-browse-origin.rst

84 lines

uri-scheme-browse-revision.rst

3 lines

uri-scheme-browse-snapshot.rst

10 lines

uri-scheme-browse.rst

21 lines

swh/

web/

admin/

14 lines

api/

views/

57 lines

21 lines

assets/

src/

bundles/

admin/

8 lines

browse/

origin-search.js

3 lines

save/

14 lines

browse/

47 lines

views/

4 lines

4 lines

105 lines

8 lines

18 lines

4 lines

utils/

snapshot_context.py

55 lines

common/

migrations/

0006_rename_origin_type.py

23 lines

4 lines

74 lines

8 lines

swh_templatetags.py

12 lines

misc/

20 lines

templates/

browse/

2 lines

includes/

take-new-snapshot.html

6 lines

misc/

origin-save.html

8 lines

tests/

admin/

test_origin_save.py

14 lines

api/

views/

38 lines

test_origin_save.py

26 lines

browse/

views/

test_identifiers.py

9 lines

69 lines

test_revision.py

3 lines

common/

test_origin_save.py

2 lines

test_service.py

10 lines

misc/

test_origin_save.py

8 lines

Diff 7398

cypress/integration/origin-save.spec.js

Loading...

docs/uri-scheme-browse-origin.rst

Loading...

docs/uri-scheme-browse-revision.rst

Loading...

docs/uri-scheme-browse-snapshot.rst

Loading...

docs/uri-scheme-browse.rst

Loading...

swh/web/admin/origin_save.py

Loading...

swh/web/api/views/origin.py

Loading...

swh/web/api/views/origin_save.py

Loading...

swh/web/assets/src/bundles/admin/origin-save.js

Loading...

swh/web/assets/src/bundles/browse/origin-search.js

Loading...

swh/web/assets/src/bundles/save/index.js

Loading...

swh/web/browse/utils.py

Loading...

swh/web/browse/views/content.py

Loading...

swh/web/browse/views/directory.py

Loading...

swh/web/browse/views/origin.py

Loading...

swh/web/browse/views/release.py

Loading...

swh/web/browse/views/revision.py

Loading...

swh/web/browse/views/snapshot.py

Loading...

swh/web/browse/views/utils/snapshot_context.py

Loading...

swh/web/common/migrations/0006_rename_origin_type.py

Loading...

swh/web/common/models.py

Loading...

swh/web/common/origin_save.py

Loading...

swh/web/common/service.py

Loading...

swh/web/common/swh_templatetags.py

Loading...

swh/web/misc/origin_save.py

Loading...

swh/web/templates/browse/search.html

Loading...

swh/web/templates/includes/take-new-snapshot.html

Loading...

swh/web/templates/misc/origin-save.html

Loading...

swh/web/tests/admin/test_origin_save.py

Loading...

swh/web/tests/api/views/test_origin.py

Loading...

swh/web/tests/api/views/test_origin_save.py

Loading...

swh/web/tests/browse/views/test_identifiers.py

Loading...

swh/web/tests/browse/views/test_origin.py

Loading...

swh/web/tests/browse/views/test_revision.py

Loading...

swh/web/tests/common/test_origin_save.py

Loading...

swh/web/tests/common/test_service.py

Loading...

swh/web/tests/misc/test_origin_save.py

Loading...