Differential D2159

model: Don't export origin['type']
ClosedPublic
Actions

Authored by olasd on Oct 18 2019, 11:58 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDMOD7a9fc3964373: model: Don't export origin['type']

Summary

This prepares the removal of origin.type from swh.model

Test Plan

tox, with added round-trip test for origins

Diff Detail

Repository

rDMOD Data model

Branch

remove-origin-type

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 8539
Build 12407: tox-on-jenkins	Jenkins
Build 12406: arc lint + arc unit

Event Timeline

olasd created this revision.Oct 18 2019, 11:58 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 18 2019, 11:58 AM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/136/ for more details.

Harbormaster completed remote builds in B8539: Diff 7341.Oct 18 2019, 12:00 PM

ardumont accepted this revision.Oct 18 2019, 12:18 PM

This revision is now accepted and ready to land.Oct 18 2019, 12:18 PM

I'm not sure that's a good idea. What about this:

if r['type'] is None:
    del r['type']

In D2159#50712, @vlorentz wrote:
I'm not sure that's a good idea. What about this:
if r['type'] is None:
    del r['type']

No. I want to ignore the argument, whatever it may be.

olasd added a child revision: D2160: Don't export origin_visit['origin']['type'].Oct 18 2019, 1:27 PM

Closed by commit rDMOD7a9fc3964373: model: Don't export origin['type'] (authored by olasd). · Explain WhyOct 18 2019, 5:06 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDMOD7a9fc3964373: model: Don't export origin['type'].

Revision Contents
Changeset List

Path

Size

swh/

model/

model.py

5 lines

tests/

test_model.py

14 lines

Diff 7341

View Options

swh/model/model.py