Page MenuHomeSoftware Heritage
Differential D2105

api: make backend_factory argument of RPCServerApp() optional
ClosedPublic
Actions

Authored by douardda on Oct 9 2019, 5:39 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDCORE36ac7a696554: api: make backend_factory argument of RPCServerApp() optional
Summary

defaults to calling the backend_class constructor.

Depends on D2104

Diff Detail

Repository
rDCORE Foundations and core functionalities
Branch
master
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 8245
Build 11904: tox-on-jenkinsJenkins
Build 11903: arc lint + arc unit

Event Timeline

douardda created this revision.Oct 9 2019, 5:39 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 9 2019, 5:39 PM
douardda added a child revision: D2106: api: use content negotiation in RPCServerApp's automagic endpoint injection.Oct 9 2019, 5:40 PM
swh-public-ci added a comment.Oct 9 2019, 5:45 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/307/ for more details.

Harbormaster completed remote builds in B8245: Diff 7052.Oct 9 2019, 5:45 PM
vlorentz requested changes to this revision.Oct 9 2019, 5:49 PM
vlorentz added a subscriber: vlorentz.

Should be documented

This revision now requires changes to proceed.Oct 9 2019, 5:49 PM
vlorentz added a comment.Oct 9 2019, 5:50 PM

and the type in the doc of backend_class should use Optional[] too

douardda updated this revision to Diff 7092.Oct 10 2019, 4:21 PM

Update the docstring

swh-public-ci added a comment.Oct 10 2019, 4:24 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/311/ for more details.

Harbormaster completed remote builds in B8293: Diff 7092.Oct 10 2019, 4:24 PM
vlorentz accepted this revision.Oct 11 2019, 10:35 AM
This revision is now accepted and ready to land.Oct 11 2019, 10:35 AM
Closed by commit rDCORE36ac7a696554: api: make backend_factory argument of RPCServerApp() optional (authored by douardda). · Explain WhyOct 11 2019, 10:42 AM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDCORE36ac7a696554: api: make backend_factory argument of RPCServerApp() optional.

Revision Contents
Changeset List

PathSize
swh/
core/
api/
3 lines

Diff 7052

View Options

swh/core/api/__init__.py

Loading...
About · Developer information · Legal